X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2F_PDCLIB%2Fprint.c;h=3ddf11daad8d7188e027222bd594d319cc876b08;hb=2f2fa4783d94d90a7bd261d070c2b5d8b790d78a;hp=9a30ca2446b0d332784fdecebfa7d12b0b55b94f;hpb=15cd62244797b9aeb3279484f8e760778c52bc4e;p=pdclib diff --git a/functions/_PDCLIB/print.c b/functions/_PDCLIB/print.c index 9a30ca2..3ddf11d 100644 --- a/functions/_PDCLIB/print.c +++ b/functions/_PDCLIB/print.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef REGTEST @@ -61,6 +62,10 @@ do { \ static void intformat( intmax_t value, struct _PDCLIB_status_t * status ) { + if ( status->prec < 0 ) + { + status->prec = 1; + } /* At worst, we need two prefix characters (hex prefix). */ char preface[3] = "\0"; size_t preidx = 0; @@ -91,18 +96,22 @@ static void intformat( intmax_t value, struct _PDCLIB_status_t * status ) } } { - size_t prec_pads = ( status->prec > status->current ) ? ( status->prec - status->current ) : 0; + /* At this point, status->current has the number of digits queued up. + Determine if we have a precision requirement to pad those. + */ + size_t prec_pads = ( (_PDCLIB_size_t)status->prec > status->current ) ? ( (_PDCLIB_size_t)status->prec - status->current ) : 0; if ( ! ( status->flags & ( E_minus | E_zero ) ) ) { /* Space padding is only done if no zero padding or left alignment - is requested. Leave space for any prefixes determined above. + is requested. Calculate the number of characters that WILL be + printed, including any prefixes determined above. */ /* The number of characters to be printed, plus prefixes if any. */ /* This line contained probably the most stupid, time-wasting bug I've ever perpetrated. Greetings to Samface, DevL, and all sceners at Breakpoint 2006. */ - size_t characters = preidx + ( ( status->current > status->prec ) ? status->current : status->prec ); + size_t characters = preidx + ( ( status->current > (_PDCLIB_size_t)status->prec ) ? status->current : (_PDCLIB_size_t)status->prec ); if ( status->width > characters ) { for ( size_t i = 0; i < status->width - characters; ++i ) @@ -119,6 +128,12 @@ static void intformat( intmax_t value, struct _PDCLIB_status_t * status ) PUT( preface[ preidx++ ] ); ++(status->current); } + /* Do the precision padding if necessary. */ + while ( prec_pads-- > 0 ) + { + PUT( '0' ); + ++(status->current); + } if ( ( ! ( status->flags & E_minus ) ) && ( status->flags & E_zero ) ) { /* If field is not left aligned, and zero padding is requested, do @@ -130,11 +145,6 @@ static void intformat( intmax_t value, struct _PDCLIB_status_t * status ) ++(status->current); } } - /* Do the precision padding if necessary. */ - for ( size_t i = 0; i < prec_pads; ++i ) - { - PUT( '0' ); - } } } @@ -189,6 +199,55 @@ static void int2base( intmax_t value, struct _PDCLIB_status_t * status ) } +static void stringformat( const char * s, struct _PDCLIB_status_t * status ) +{ + if ( status->flags & E_char ) + { + status->prec = 1; + } + else + { + if ( status->prec < 0 ) + { + status->prec = strlen( s ); + } + else + { + for ( int i = 0; i < status->prec; ++i ) + { + if ( s[i] == 0 ) + { + status->prec = i; + break; + } + } + } + } + if ( ! ( status->flags & E_minus ) && ( status->width > (_PDCLIB_size_t)status->prec ) ) + { + while ( status->current < ( status->width - status->prec ) ) + { + PUT( ' ' ); + ++(status->current); + } + } + while ( status->prec > 0 ) + { + PUT( *(s++) ); + --(status->prec); + ++(status->current); + } + if ( status->flags & E_minus ) + { + while ( status->width > status->current ) + { + PUT( ' ' ); + ++(status->current); + } + } +} + + const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status ) { const char * orig_spec = spec; @@ -203,7 +262,7 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status status->base = 0; status->current = 0; status->width = 0; - status->prec = 0; + status->prec = EOF; /* First come 0..n flags */ do @@ -278,6 +337,7 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status EOF (negative), there is no need for testing for negative here. */ status->prec = va_arg( status->arg, int ); + ++spec; } else { @@ -285,8 +345,8 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status status->prec = (int)strtol( spec, &endptr, 10 ); if ( spec == endptr ) { - /* Decimal point but no number - bad conversion specifier. */ - return orig_spec; + /* Decimal point but no number - equals zero */ + status->prec = 0; } spec = endptr; } @@ -383,21 +443,19 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status case 'A': break; case 'c': - /* TODO: Flags, wide chars. */ - PUT( va_arg( status->arg, int ) ); - return ++spec; - case 's': - /* TODO: Flags, wide chars. */ + /* TODO: wide chars. */ { - char * s = va_arg( status->arg, char * ); - while ( *s != '\0' ) - { - PUT( *(s++) ); - } + char c[1]; + c[0] = (char)va_arg( status->arg, int ); + status->flags |= E_char; + stringformat( c, status ); return ++spec; } + case 's': + /* TODO: wide chars. */ + stringformat( va_arg( status->arg, char * ), status ); + return ++spec; case 'p': - /* TODO: E_long -> E_intptr */ status->base = 16; status->flags |= ( E_lower | E_unsigned | E_alt | E_pointer ); break; @@ -448,10 +506,9 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status return NULL; } ++(status->current); - /* FIXME: The if clause means one-digit values do not get formatted */ - /* Was introduced originally to get value to "safe" levels re. uintmax_t. */ if ( ( value / status->base ) != 0 ) { + /* Get value to "safe" levels re. uintmax_t. */ int2base( (intmax_t)(value / status->base), status ); } else