X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2F_PDCLIB%2Fprint.c;h=c36b00978ec7d7fd627087f117538472aaa4571c;hb=0d54a75af25ca44411e7c4190cc2a93a390e61a2;hp=95e71c6c5a8ab979c25dc1fac5606576cecbc9a1;hpb=a20eb8b4b7f5e39f97cfe1b7939ea6548d01abd1;p=pdclib.old diff --git a/functions/_PDCLIB/print.c b/functions/_PDCLIB/print.c index 95e71c6..c36b009 100644 --- a/functions/_PDCLIB/print.c +++ b/functions/_PDCLIB/print.c @@ -15,6 +15,7 @@ /* Using an integer's bits as flags for both the conversion flags and length modifiers. */ +/* FIXME: one too many flags to work on a 16-bit machine */ #define E_minus 1<<0 #define E_plus 1<<1 #define E_alt 1<<2 @@ -39,17 +40,14 @@ i - pointer to number of characters already delivered in this call n - pointer to maximum number of characters to be delivered in this call s - the buffer into which the character shall be delivered + FIXME: ref. fputs() for a better way to buffer handling */ #define DELIVER( x ) \ do { \ if ( status->i < status->n ) { \ - if ( status->stream != NULL ) { \ - status->stream->buffer[status->stream->bufidx++] = x; \ - if ( ( status->stream->bufidx == status->stream->bufsize ) \ - || ( ( status->stream->status & _IOLBF ) && ( x == '\n' ) ) \ - || ( status->stream->status & _IONBF ) ) \ - fflush( status->stream ); \ - } else \ + if ( status->stream != NULL ) \ + putc( x, status->stream ); \ + else \ status->s[status->i] = x; \ } \ ++(status->i); \ @@ -531,9 +529,18 @@ const char * _PDCLIB_print( const char * spec, struct _PDCLIB_status_t * status static int testprintf( char * buffer, size_t n, const char * format, ... ) { /* Members: base, flags, n, i, this, s, width, prec, stream, arg */ - struct _PDCLIB_status_t status = { 0, 0, n, 0, 0, buffer, 0, 0, NULL, NULL }; - memset( buffer, '\0', 100 ); + struct _PDCLIB_status_t status; + status.base = 0; + status.flags = 0; + status.n = n; + status.i = 0; + status.this = 0; + status.s = buffer; + status.width = 0; + status.prec = 0; + status.stream = NULL; va_start( status.arg, format ); + memset( buffer, '\0', 100 ); if ( *(_PDCLIB_print( format, &status )) != '\0' ) { printf( "_PDCLIB_print() did not return end-of-specifier on '%s'.\n", format );