X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdio%2Ffclose.c;h=dc27fe2eb1555a5e36bd7ceb513390d675baf415;hb=8024ab6eb8c841b330458354788d7f3a86bee7dd;hp=f633de3e8cf1364cf7583dfa52e635e600fe4d58;hpb=188eee8e94ce6e968e0791bae1c7682dafe9ec9c;p=pdclib

diff --git a/functions/stdio/fclose.c b/functions/stdio/fclose.c
index f633de3..dc27fe2 100644
--- a/functions/stdio/fclose.c
+++ b/functions/stdio/fclose.c
@@ -14,7 +14,6 @@
 
 extern struct _PDCLIB_file_t * _PDCLIB_filelist;
 
-/* FIXME: Last file not removed from list. */
 int fclose( struct _PDCLIB_file_t * stream )
 {
     struct _PDCLIB_file_t * current = _PDCLIB_filelist;
@@ -24,22 +23,34 @@ int fclose( struct _PDCLIB_file_t * stream )
     {
         if ( stream == current )
         {
-            if ( stream->status & _PDCLIB_WROTELAST ) fflush( stream );
-            if ( stream->status & _PDCLIB_LIBBUFFER ) free( stream->buffer );
+            /* Flush buffer */
+            if ( stream->status & _PDCLIB_FWRITE )
+            {
+                if ( _PDCLIB_flushbuffer( stream ) == EOF )
+                {
+                    /* Flush failed, errno already set */
+                    return EOF;
+                }
+            }
+            /* Close handle */
             _PDCLIB_close( stream->handle );
+            /* Remove stream from list */
             if ( previous != NULL )
             {
-                previous->next = current->next;
+                previous->next = stream->next;
             }
             else
             {
-                _PDCLIB_filelist = current->next;
+                _PDCLIB_filelist = stream->next;
             }
+            /* Free stream */
+            free( stream );
             return 0;
         }
         previous = current;
         current = current->next;
     }
+    _PDCLIB_errno = _PDCLIB_EIO;
     return -1;
 }
 
@@ -51,10 +62,11 @@ int fclose( struct _PDCLIB_file_t * stream )
 int main( void )
 {
 #ifndef REGTEST
-    /* FIXME: This is basically fopen() checking. Flushing and buffer-freeing is not checked. */
     struct _PDCLIB_file_t * file1;
     struct _PDCLIB_file_t * file2;
-    TESTCASE( _PDCLIB_filelist == NULL );
+    remove( "testfile1" );
+    remove( "testfile2" );
+    TESTCASE( _PDCLIB_filelist == stdin );
     TESTCASE( ( file1 = fopen( "testfile1", "w" ) ) != NULL );
     TESTCASE( _PDCLIB_filelist == file1 );
     TESTCASE( ( file2 = fopen( "testfile2", "w" ) ) != NULL );
@@ -66,8 +78,9 @@ int main( void )
     TESTCASE( fclose( file1 ) == 0 );
     TESTCASE( _PDCLIB_filelist == file2 );
     TESTCASE( fclose( file2 ) == 0 );
-    TESTCASE( _PDCLIB_filelist == NULL ); /* FIXME: fails */
-    system( "rm testfile1 testfile2" );
+    TESTCASE( _PDCLIB_filelist == stdin );
+    remove( "testfile1" );
+    remove( "testfile2" );
 #else
     puts( " NOTEST fclose() test driver is PDCLib-specific." );
 #endif
@@ -75,3 +88,4 @@ int main( void )
 }
 
 #endif
+