X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdio%2Ffopen.c;h=48c07d2b3ff41d6c2244461bc417832546063161;hb=0d54a75af25ca44411e7c4190cc2a93a390e61a2;hp=14ce3a8f57b2fe8911baba2c941f0529c76050a0;hpb=76aab9d24d750a2e639eb878d5907a8bcfab08cf;p=pdclib.old

diff --git a/functions/stdio/fopen.c b/functions/stdio/fopen.c
index 14ce3a8..48c07d2 100644
--- a/functions/stdio/fopen.c
+++ b/functions/stdio/fopen.c
@@ -12,8 +12,7 @@
 #ifndef REGTEST
 #include <_PDCLIB_glue.h>
 
-/* FIXME: This approach is a possible attack vector. */
-struct _PDCLIB_file_t * _PDCLIB_filelist = NULL;
+extern struct _PDCLIB_file_t * _PDCLIB_filelist;
 
 struct _PDCLIB_file_t * fopen( const char * _PDCLIB_restrict filename, const char * _PDCLIB_restrict mode )
 {
@@ -28,22 +27,44 @@ struct _PDCLIB_file_t * fopen( const char * _PDCLIB_restrict filename, const cha
         /* no memory for another FILE */
         return NULL;
     }
-    if ( ( rc->status = _PDCLIB_filemode( mode ) ) == 0 ) goto fail; /* invalid mode */
+    if ( ( rc->status = _PDCLIB_filemode( mode ) ) == 0 ) 
+    {
+        /* invalid mode */
+        free( rc );
+        return NULL;
+    }
     rc->handle = _PDCLIB_open( filename, rc->status );
-    if ( rc->handle == _PDCLIB_NOHANDLE ) goto fail; /* OS open() failed */
+    if ( rc->handle == _PDCLIB_NOHANDLE )
+    {
+        /* OS open() failed */
+        free( rc );
+        return NULL;
+    }
     /* Adding to list of open files */
     rc->next = _PDCLIB_filelist;
     _PDCLIB_filelist = rc;
     /* Setting buffer, and mark as internal. TODO: Check for unbuffered */
-    if ( ( rc->buffer = malloc( BUFSIZ ) ) == NULL ) goto fail;
+    if ( ( rc->buffer = malloc( BUFSIZ ) ) == NULL )
+    {
+        free( rc );
+        return NULL;
+    }
+    if ( ( rc->ungetbuf = malloc( _PDCLIB_UNGETCBUFSIZE ) ) == NULL )
+    {
+       free( rc->buffer );
+       free( rc );
+       return NULL;
+    }
     rc->bufsize = BUFSIZ;
     rc->bufidx = 0;
-    rc->status |= ( _PDCLIB_LIBBUFFER | _PDCLIB_VIRGINSTR );
+    rc->ungetidx = 0;
+    /* Setting buffer to _IOLBF because "when opened, a stream is fully
+       buffered if and only if it can be determined not to refer to an
+       interactive device."
+    */
+    rc->status |= _PDCLIB_LIBBUFFER | _IOLBF;
     /* TODO: Setting mbstate */
     return rc;
-fail:
-    free( rc );
-    return NULL;
 }
 
 #endif
@@ -53,15 +74,20 @@ fail:
 
 int main( void )
 {
-    TESTCASE( fopen( NULL, NULL ) == NULL );
+    /* Some of the tests are not executed for regression tests, as the libc on
+       my system is at once less forgiving (segfaults on mode NULL) and more
+       forgiving (accepts undefined modes).
+    */
+    remove( "testfile" );
+    TESTCASE_NOREG( fopen( NULL, NULL ) == NULL );
     TESTCASE( fopen( NULL, "w" ) == NULL );
-    TESTCASE( fopen( "", NULL ) == NULL );
+    TESTCASE_NOREG( fopen( "", NULL ) == NULL );
     TESTCASE( fopen( "", "w" ) == NULL );
     TESTCASE( fopen( "foo", "" ) == NULL );
-    TESTCASE( fopen( "testfile", "wq" ) == NULL ); /* Illegal mode */
-    TESTCASE( fopen( "testfile", "wr" ) == NULL ); /* Illegal mode */
+    TESTCASE_NOREG( fopen( "testfile", "wq" ) == NULL ); /* Undefined mode */
+    TESTCASE_NOREG( fopen( "testfile", "wr" ) == NULL ); /* Undefined mode */
     TESTCASE( fopen( "testfile", "w" ) != NULL );
-    system( "rm testfile" );
+    remove( "testfile" );
     return TEST_RESULTS;
 }