X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdio%2Ffreopen.c;h=741731b9990b8b4b3dcfdbb46860812ac91afd16;hb=d69469f15e30e4ee7cd8f11edd7ad87196a92d44;hp=2d900fd510dfeab1cc26ca1ea9d046bef2b10f78;hpb=d451ae8a715aa5fe6f2fb6f4d2494b11f4d11f2f;p=pdclib diff --git a/functions/stdio/freopen.c b/functions/stdio/freopen.c index 2d900fd..741731b 100644 --- a/functions/stdio/freopen.c +++ b/functions/stdio/freopen.c @@ -14,9 +14,17 @@ #include #include -struct _PDCLIB_file_t * freopen( const char * _PDCLIB_restrict filename, const char * _PDCLIB_restrict mode, struct _PDCLIB_file_t * _PDCLIB_restrict stream ) +struct _PDCLIB_file_t * freopen( + const char * _PDCLIB_restrict filename, + const char * _PDCLIB_restrict mode, + struct _PDCLIB_file_t * _PDCLIB_restrict stream ) { - unsigned int status = stream->status & ( _IONBF | _IOLBF | _IOFBF | _PDCLIB_FREEBUFFER | _PDCLIB_DELONCLOSE ); + flockfile( stream ); + + unsigned int status = stream->status & + ( _IONBF | _IOLBF | _IOFBF | _PDCLIB_FREEBUFFER + | _PDCLIB_DELONCLOSE | _PDCLIB_STATIC ); + /* TODO: This function can change wide orientation of a stream */ if ( stream->status & _PDCLIB_FWRITE ) { @@ -25,9 +33,11 @@ struct _PDCLIB_file_t * freopen( const char * _PDCLIB_restrict filename, const c if ( ( filename == NULL ) && ( stream->filename == NULL ) ) { /* TODO: Special handling for mode changes on std-streams */ + funlockfile( stream ); return NULL; } - _PDCLIB_close( stream->handle ); + stream->ops->close(stream->handle); + /* TODO: It is not nice to do this on a stream we just closed. It does not matter with the current implementation of clearerr(), but it might start to matter if someone replaced that implementation. @@ -49,16 +59,19 @@ struct _PDCLIB_file_t * freopen( const char * _PDCLIB_restrict filename, const c /* Allocate new buffer */ if ( ( stream->filename = (char *)malloc( strlen( filename ) ) ) == NULL ) { + funlockfile( stream ); return NULL; } strcpy( stream->filename, filename ); } if ( ( mode == NULL ) || ( filename[0] == '\0' ) ) { + funlockfile( stream ); return NULL; } if ( ( stream->status = _PDCLIB_filemode( mode ) ) == 0 ) { + funlockfile( stream ); return NULL; } /* Re-add the flags we saved above */ @@ -67,10 +80,13 @@ struct _PDCLIB_file_t * freopen( const char * _PDCLIB_restrict filename, const c stream->bufend = 0; stream->ungetidx = 0; /* TODO: Setting mbstate */ - if ( ( stream->handle = _PDCLIB_open( filename, stream->status ) ) == _PDCLIB_NOHANDLE ) + if ( ! _PDCLIB_open( &stream->handle, &stream->ops, filename, + stream->status ) ) { + funlockfile( stream ); return NULL; } + funlockfile( stream ); return stream; } @@ -96,8 +112,8 @@ int main( void ) TESTCASE( fclose( fin ) == 0 ); TESTCASE( fclose( fout ) == 0 ); - remove( testfile1 ); - remove( testfile2 ); + TESTCASE( remove( testfile1 ) == 0 ); + TESTCASE( remove( testfile2 ) == 0 ); return TEST_RESULTS; }