X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdio%2Fftell.c;h=e392a8b1f01de37121a2683c6a8ab2643f4d326d;hb=f495ef679088649341da616b815ddc7ff60cec7b;hp=9ca449fe54a155d14bb747f0dca137aac8ede6c5;hpb=393020b6e48719d27699dea6b29e53025bbd5123;p=pdclib

diff --git a/functions/stdio/ftell.c b/functions/stdio/ftell.c
index 9ca449f..e392a8b 100644
--- a/functions/stdio/ftell.c
+++ b/functions/stdio/ftell.c
@@ -13,20 +13,33 @@
 
 long int ftell( struct _PDCLIB_file_t * stream )
 {
-    /* TODO: A bit too fuzzy in the head now. stream->ungetidx should be in here
-             somewhere.
+    /* ftell() must take into account:
+       - the actual *physical* offset of the file, i.e. the offset as recognized
+         by the operating system (and stored in stream->pos.offset); and
+       - any buffers held by PDCLib, which
+         - in case of unwritten buffers, count in *addition* to the offset; or
+         - in case of unprocessed pre-read buffers, count in *substraction* to
+           the offset. (Remember to count ungetidx into this number.)
+       Conveniently, the calculation ( ( bufend - bufidx ) + ungetidx ) results
+       in just the right number in both cases:
+         - in case of unwritten buffers, ( ( 0 - unwritten ) + 0 )
+           i.e. unwritten bytes as negative number
+         - in case of unprocessed pre-read, ( ( preread - processed ) + unget )
+           i.e. unprocessed bytes as positive number.
+       That is how the somewhat obscure return-value calculation works.
     */
-    if ( stream->pos.offset > ( LONG_MAX - stream->bufidx ) )
+    /* If offset is too large for return type, report error instead of wrong
+       offset value. Buffers may not be larger than INT_MAX so the casts are
+       safe.
+    */
+    /* FIXME: This calculation *underflows* when offset smaller than pre-read */
+    if ( ( stream->pos.offset - ( (int)stream->bufend + (int)stream->ungetidx ) ) > ( LONG_MAX - stream->bufidx ) )
     {
         /* integer overflow */
-        _PDCLIB_errno = _PDCLIB_EINVAL;
+        _PDCLIB_errno = _PDCLIB_ERANGE;
         return -1;
     }
-    /* Position of start-of-buffer, plus:
-       - buffered, unwritten content (for output streams), or
-       - already-parsed content from buffer (for input streams)
-    */
-    return (long int)( stream->pos.offset + stream->bufidx - stream->ungetidx );
+    return (long int)( stream->pos.offset - ( ( (int)stream->bufend - (int)stream->bufidx ) + stream->ungetidx ) );
 }
 
 #endif
@@ -44,12 +57,11 @@ int main( void )
     */
     /* The following functions delegate their tests to here:
        fgetc fflush rewind fputc ungetc fseek
-       flushbuffer seek fillbuffer
+       flushbuffer seek fillbuffer prepread prepwrite
     */
     char * buffer = (char*)malloc( 4 );
     FILE * fh;
-    remove( "testfile" );
-    TESTCASE( ( fh = fopen( "testfile", "w+" ) ) != NULL );
+    TESTCASE( ( fh = tmpfile() ) != NULL );
     TESTCASE( setvbuf( fh, buffer, _IOLBF, 4 ) == 0 );
     TESTCASE( fputc( '1', fh ) == '1' );
     TESTCASE( fputc( '2', fh ) == '2' );
@@ -75,9 +87,8 @@ int main( void )
     TESTCASE_NOREG( fh->bufidx == 0 );
     /* Reading back first character after rewind for basic read check */
     TESTCASE( fgetc( fh ) == '1' );
-    TESTCASE( fclose( fh ) == 0 );
     /* TODO: t.b.c. */
-    remove( "testfile" );
+    TESTCASE( fclose( fh ) == 0 );
     return TEST_RESULTS;
 }