X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdlib%2Fstrtol.c;h=dce035ea1f9bd8a254b36ce9cde74f4e18bbcb63;hb=3c7e677c7a6b43ce8bd12021e0af280f08009777;hp=ff5aa8b0cb791609f0bbe526248fd54d135b0825;hpb=a381f50d5325748b70096ac5f5d3f63ae4f6e18a;p=pdclib diff --git a/functions/stdlib/strtol.c b/functions/stdlib/strtol.c index ff5aa8b..dce035e 100644 --- a/functions/stdlib/strtol.c +++ b/functions/stdlib/strtol.c @@ -84,11 +84,11 @@ int main( void ) endptr = NULL; TESTCASE( strtol( overflow, &endptr, 0 ) == 0 ); TESTCASE( endptr == overflow ); - /* These tests assume two-complement, but conversion should work for */ - /* one-complement and signed magnitude just as well. Anyone having a */ - /* platform to test this on? */ + /* TODO: These tests assume two-complement, but conversion should work */ + /* for one-complement and signed magnitude just as well. Anyone having */ + /* a platform to test this on? */ errno = 0; -#if LONG_MAX == 0x7fffffffL +#if LONG_MAX >> 30 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtol( "2147483647", NULL, 0 ) == 0x7fffffff ); TESTCASE( errno == 0 ); @@ -105,7 +105,7 @@ int main( void ) TESTCASE( strtol( "-2147483649", NULL, 0 ) == LONG_MIN ); TESTCASE( errno == ERANGE ); /* TODO: test "odd" overflow, i.e. base is not power of two */ -#elif LONG_MAX == 0x7fffffffffffffffL +#elif LONG_MAX >> 62 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtol( "9223372036854775807", NULL, 0 ) == 0x7fffffffffffffff ); TESTCASE( errno == 0 );