X-Git-Url: https://pd.if.org/git/?a=blobdiff_plain;f=functions%2Fstdlib%2Fstrtoll.c;h=41640a159e074a632540410f805a1b72026bf2a5;hb=3390783767fc2810c5b1261fca213ee0ccf8cc8f;hp=13a1a1de6cf609b27784b0b1262dd9bb76102d8f;hpb=a381f50d5325748b70096ac5f5d3f63ae4f6e18a;p=pdclib diff --git a/functions/stdlib/strtoll.c b/functions/stdlib/strtoll.c index 13a1a1d..41640a1 100644 --- a/functions/stdlib/strtoll.c +++ b/functions/stdlib/strtoll.c @@ -84,11 +84,11 @@ int main( void ) endptr = NULL; TESTCASE( strtoll( overflow, &endptr, 0 ) == 0 ); TESTCASE( endptr == overflow ); - /* These tests assume two-complement, but conversion should work for */ - /* one-complement and signed magnitude just as well. Anyone having a */ - /* platform to test this on? */ + /* TODO: These tests assume two-complement, but conversion should work */ + /* for one-complement and signed magnitude just as well. Anyone having */ + /* a platform to test this on? */ errno = 0; -#if LLONG_MAX == 0x7fffffffffffffffLL +#if LLONG_MAX >> 62 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtoll( "9223372036854775807", NULL, 0 ) == 0x7fffffffffffffff ); TESTCASE( errno == 0 ); @@ -102,7 +102,7 @@ int main( void ) TESTCASE( strtoll( "-9223372036854775809", NULL, 0 ) == LLONG_MIN ); TESTCASE( errno == ERANGE ); /* TODO: test "odd" overflow, i.e. base is not power of two */ -#elif LLONG_MAX == 0x7fffffffffffffffffffffffffffffffLL +#elif LLONG_MAX >> 126 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtoll( "170141183460469231731687303715884105728", NULL, 0 ) == 0x7fffffffffffffffffffffffffffffff ); TESTCASE( errno == 0 );