]> pd.if.org Git - btree/commitdiff
Rework reader/writer locks, fix BtLockParent usage
authorunknown <karl@E04.petzent.com>
Tue, 18 Feb 2014 22:19:09 +0000 (14:19 -0800)
committerunknown <karl@E04.petzent.com>
Tue, 18 Feb 2014 22:19:09 +0000 (14:19 -0800)
threads2h.c
threads2i.c
threads2j.c

index 11fb8b457962a71e3ef6eeb75af24220f1295191..46742c487497d05185dd795028a54aadb46ff4db 100644 (file)
@@ -1,6 +1,6 @@
-// btree version threads2h pthread rw lock version
-//     with reworked bt_deletekey code
-// 12 FEB 2014
+// btree version threads2h pthread rw lock/SRW version
+//     with fixed bt_deletekey code
+// 17 FEB 2014
 
 // author: karl malbrain, malbrain@cal.berkeley.edu
 
@@ -89,22 +89,15 @@ typedef enum{
 
 //     mode & definition for latch implementation
 
-enum {
-       Mutex = 1,
-       Write = 2,
-       Pending = 4,
-       Share = 8
-} LockMode;
-
 // exclusive is set for write access
 // share is count of read accessors
 // grant write lock when share == 0
 
 typedef struct {
-       volatile ushort mutex:1;
-       volatile ushort exclusive:1;
-       volatile ushort pending:1;
-       volatile ushort share:13;
+       volatile unsigned char mutex;
+       volatile unsigned char exclusive:1;
+       volatile unsigned char pending:1;
+       volatile ushort share;
 } BtSpinLatch;
 
 //  hash table entries
@@ -177,13 +170,11 @@ typedef struct BtPage_ {
        uint min;                                       // next key offset
        unsigned char bits:7;           // page size in bits
        unsigned char free:1;           // page is on free list
-       unsigned char lvl:4;            // level of page
+       unsigned char lvl:5;            // level of page
        unsigned char kill:1;           // page is being killed
        unsigned char dirty:1;          // page has deleted keys
        unsigned char posted:1;         // page fence is posted
-       unsigned char goright:1;        // page is being killed, continue to right
        unsigned char right[BtId];      // page number to right
-       unsigned char fence[256];       // page fence key
 } *BtPage;
 
 //     The memory mapping pool table buffer manager entry
@@ -274,15 +265,12 @@ typedef enum {
 // B-Tree functions
 extern void bt_close (BtDb *bt);
 extern BtDb *bt_open (BtMgr *mgr);
-extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl);
-extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len);
+extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod);
+extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl);
 extern uid bt_findkey    (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_startkey  (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_nextkey   (BtDb *bt, uint slot);
 
-//     internal functions
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence);
-
 //     manager functions
 extern BtMgr *bt_mgr (char *name, uint mode, uint bits, uint poolsize, uint segsize, uint hashsize);
 void bt_mgrclose (BtMgr *mgr);
@@ -385,29 +373,26 @@ ushort prev;
   do {
        //      obtain latch mutex
 #ifdef unix
-       if( __sync_fetch_and_or((ushort *)latch, Mutex) & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                continue;
 #else
-       if( prev = _InterlockedOr16((ushort *)latch, Mutex) & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                continue;
 #endif
        //  see if exclusive request is granted or pending
 
        if( prev = !(latch->exclusive | latch->pending) )
-#ifdef unix
-               __sync_fetch_and_add((ushort *)latch, Share);
-#else
-               _InterlockedExchangeAdd16 ((ushort *)latch, Share);
-#endif
+               latch->share++;
 
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 
        if( prev )
                return;
+
 #ifdef  unix
   } while( sched_yield(), 1 );
 #else
@@ -419,31 +404,27 @@ ushort prev;
 
 void bt_spinwritelock(BtSpinLatch *latch)
 {
+uint prev;
+
   do {
 #ifdef  unix
-       if( __sync_fetch_and_or((ushort *)latch, Mutex | Pending) & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                continue;
 #else
-       if( _InterlockedOr16((ushort *)latch, Mutex | Pending) & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                continue;
 #endif
-       if( !(latch->share | latch->exclusive) ) {
+       if( prev = !(latch->share | latch->exclusive) )
+               latch->exclusive = 1, latch->pending = 0;
+       else
+               latch->pending = 1;
 #ifdef unix
-               __sync_fetch_and_or((ushort *)latch, Write);
-               __sync_fetch_and_and ((ushort *)latch, ~(Mutex | Pending));
+       __sync_lock_release (&latch->mutex);
 #else
-               _InterlockedOr16((ushort *)latch, Write);
-               _InterlockedAnd16((ushort *)latch, ~(Mutex | Pending));
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
+       if( prev )
                return;
-       }
-
-#ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
-#else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
-#endif
-
 #ifdef  unix
   } while( sched_yield(), 1 );
 #else
@@ -458,40 +439,45 @@ void bt_spinwritelock(BtSpinLatch *latch)
 
 int bt_spinwritetry(BtSpinLatch *latch)
 {
-ushort prev;
+uint prev;
 
 #ifdef unix
-       if( prev = __sync_fetch_and_or((ushort *)latch, Mutex), prev & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                return 0;
 #else
-       if( prev = _InterlockedOr16((ushort *)latch, Mutex), prev & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                return 0;
 #endif
        //      take write access if all bits are clear
 
-       if( !prev )
-#ifdef unix
-               __sync_fetch_and_or ((ushort *)latch, Write);
-#else
-               _InterlockedOr16((ushort *)latch, Write);
-#endif
+       if( prev = !(latch->exclusive | latch->share) )
+               latch->exclusive = 1;
 
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
-       return !prev;
+       return prev;
 }
 
 //     clear write mode
 
 void bt_spinreleasewrite(BtSpinLatch *latch)
 {
+       //      obtain latch mutex
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Write);
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
+               sched_yield();
 #else
-       _InterlockedAnd16((ushort *)latch, ~Write);
+       while( _InterlockedExchange8(&latch->mutex, 1) )
+               SwitchToThread();
+#endif
+       latch->exclusive = 0;
+#ifdef unix
+       __sync_lock_release (&latch->mutex);
+#else
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 }
 
@@ -500,9 +486,17 @@ void bt_spinreleasewrite(BtSpinLatch *latch)
 void bt_spinreleaseread(BtSpinLatch *latch)
 {
 #ifdef unix
-       __sync_fetch_and_add((ushort *)latch, -Share);
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
+               sched_yield();
+#else
+       while( _InterlockedExchange8(&latch->mutex, 1) )
+               SwitchToThread();
+#endif
+       latch->share--;
+#ifdef unix
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedExchangeAdd16 ((ushort *)latch, -Share);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 }
 
@@ -829,6 +823,7 @@ BtLatchMgr *latchmgr;
 off64_t size;
 uint amt[1];
 BtMgr* mgr;
+BtKey key;
 int flag;
 
 #ifndef unix
@@ -968,12 +963,13 @@ SYSTEM_INFO sysinfo[1];
        latchmgr->alloc->bits = mgr->page_bits;
 
        for( lvl=MIN_lvl; lvl--; ) {
-               slotptr(latchmgr->alloc, 1)->off = offsetof(struct BtPage_, fence);
+               slotptr(latchmgr->alloc, 1)->off = mgr->page_size - 3;
                bt_putid(slotptr(latchmgr->alloc, 1)->id, lvl ? MIN_lvl - lvl + 1 : 0);         // next(lower) page number
-               latchmgr->alloc->fence[0] = 2;
-               latchmgr->alloc->fence[1] = 0xff;
-               latchmgr->alloc->fence[2] = 0xff;
-               latchmgr->alloc->min = mgr->page_size;
+               key = keyptr(latchmgr->alloc, 1);
+               key->len = 2;           // create stopper key
+               key->key[0] = 0xff;
+               key->key[1] = 0xff;
+               latchmgr->alloc->min = mgr->page_size - 3;
                latchmgr->alloc->lvl = lvl;
                latchmgr->alloc->cnt = 1;
                latchmgr->alloc->act = 1;
@@ -1166,7 +1162,7 @@ int flag;
 
 #ifdef unix
        flag = PROT_READ | ( bt->mgr->mode == BT_ro ? 0 : PROT_WRITE );
-       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED | MAP_POPULATE, bt->mgr->idx, off);
+       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED, bt->mgr->idx, off);
        if( pool->map == MAP_FAILED )
                return bt->err = BTERR_map;
 #else
@@ -1458,44 +1454,38 @@ int reuse;
 int bt_findslot (BtPageSet *set, unsigned char *key, uint len)
 {
 uint diff, higher = set->page->cnt, low = 1, slot;
+uint good = 0;
 
        //        make stopper key an infinite fence value
 
        if( bt_getid (set->page->right) )
                higher++;
+       else
+               good++;
 
        //      low is the lowest candidate.
        //  loop ends when they meet
 
        //  higher is already
-       //      tested as .ge. the given key.
+       //      tested as .ge. the passed key.
 
        while( diff = higher - low ) {
                slot = low + ( diff >> 1 );
                if( keycmp (keyptr(set->page, slot), key, len) < 0 )
                        low = slot + 1;
                else
-                       higher = slot;
+                       higher = slot, good++;
        }
 
-       if( higher <= set->page->cnt )
-               return higher;
-
-       //      if leaf page, compare against fence value
-
        //      return zero if key is on right link page
-       //      or return slot beyond last key
-
-       if( set->page->lvl || keycmp ((BtKey)set->page->fence, key, len) < 0 )
-               return 0;
 
-       return higher;
+       return good ? higher : 0;
 }
 
 //  find and load page at given level for given key
 //     leave page rd or wr locked as requested
 
-int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, uint lock)
+int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, BtLock lock)
 {
 uid page_no = ROOT_page, prevpage = 0;
 uint drill = 0xff, slot;
@@ -1507,7 +1497,7 @@ BtPool *prevpool;
 
   do {
        // determine lock mode of drill level
-       mode = (lock == BtLockWrite) && (drill == lvl) ? BtLockWrite : BtLockRead; 
+       mode = (drill == lvl) ? lock : BtLockRead; 
 
        set->latch = bt_pinlatch (bt, page_no);
        set->page_no = page_no;
@@ -1537,6 +1527,9 @@ BtPool *prevpool;
 
        bt_lockpage(mode, set->latch);
 
+       if( set->page->free )
+               return bt->err = BTERR_struct, 0;
+
        if( page_no > ROOT_page )
          bt_unlockpage(BtLockAccess, set->latch);
 
@@ -1548,7 +1541,7 @@ BtPool *prevpool;
                        
                drill = set->page->lvl;
 
-               if( lock == BtLockWrite && drill == lvl ) {
+               if( lock != BtLockRead && drill == lvl ) {
                  bt_unlockpage(mode, set->latch);
                  bt_unpinlatch (set->latch);
                  bt_unpinpool (set->pool);
@@ -1561,53 +1554,28 @@ BtPool *prevpool;
        prevpool = set->pool;
        prevmode = mode;
 
-       //      if page is being deleted and we should continue right
-
-       if( set->page->kill && set->page->goright ) {
-               page_no = bt_getid (set->page->right);
-               continue;
-       }
-
-       //      otherwise, wait for deleted node to clear
-
-       if( set->page->kill ) {
-               bt_unlockpage(mode, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               page_no = ROOT_page;
-               prevpage = 0;
-               drill = 0xff;
-#ifdef unix
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-       
        //  find key on page at this level
        //  and descend to requested level
 
-       if( slot = bt_findslot (set, key, len) ) {
+       if( !set->page->kill )
+        if( slot = bt_findslot (set, key, len) ) {
          if( drill == lvl )
                return slot;
 
-         if( slot > set->page->cnt )
-               return bt->err = BTERR_struct;
-
          while( slotptr(set->page, slot)->dead )
                if( slot++ < set->page->cnt )
                        continue;
                else
-                       return bt->err = BTERR_struct, 0;
+                       goto slideright;
 
          page_no = bt_getid(slotptr(set->page, slot)->id);
          drill--;
          continue;
-       }
+        }
 
        //  or slide right into next page
 
+slideright:
        page_no = bt_getid(set->page->right);
 
   } while( page_no );
@@ -1618,61 +1586,6 @@ BtPool *prevpool;
   return 0;    // return error
 }
 
-// drill down fixing fence values for left sibling tree
-
-//  call with set write locked
-//     return with set unlocked & unpinned.
-
-BTERR bt_fixfences (BtDb *bt, BtPageSet *set, unsigned char *newfence)
-{
-unsigned char oldfence[256];
-BtPageSet next[1];
-int chk;
-
-  memcpy (oldfence, set->page->fence, 256);
-  next->page_no = bt_getid(slotptr(set->page, set->page->cnt)->id);
-
-  while( !set->page->kill && set->page->lvl ) {
-       next->latch = bt_pinlatch (bt, next->page_no);
-       bt_lockpage (BtLockParent, next->latch);
-       bt_lockpage (BtLockAccess, next->latch);
-       bt_lockpage (BtLockWrite, next->latch);
-       bt_unlockpage (BtLockAccess, next->latch);
-
-       if( next->pool = bt_pinpool (bt, next->page_no) )
-               next->page = bt_page (bt, next->pool, next->page_no);
-       else
-               return bt->err;
-
-       chk = keycmp ((BtKey)next->page->fence, oldfence + 1, *oldfence);
-
-       if( chk < 0 ) {
-         next->page_no = bt_getid (next->page->right);
-         bt_unlockpage (BtLockWrite, next->latch);
-         bt_unlockpage (BtLockParent, next->latch);
-         bt_unpinlatch (next->latch);
-         bt_unpinpool (next->pool);
-         continue;
-       }
-
-       if( chk > 0 )
-               return bt->err = BTERR_struct;
-
-       if( bt_fixfences (bt, next, newfence) )
-               return bt->err;
-
-       break;
-  }
-
-  memcpy (set->page->fence, newfence, 256);
-
-  bt_unlockpage (BtLockWrite, set->latch);
-  bt_unlockpage (BtLockParent, set->latch);
-  bt_unpinlatch (set->latch);
-  bt_unpinpool (set->pool);
-  return 0;
-}
-
 //     return page to free list
 //     page must be delete & write locked
 
@@ -1699,434 +1612,208 @@ void bt_freepage (BtDb *bt, BtPageSet *set)
        bt_spinreleasewrite (bt->mgr->latchmgr->lock);
 }
 
-//     remove the root level by promoting its only child
-//     call with parent and child pages
+//     a fence key was deleted from a page
+//     push new fence value upwards
 
-BTERR bt_removeroot (BtDb *bt, BtPageSet *root, BtPageSet *child)
+BTERR bt_fixfence (BtDb *bt, BtPageSet *set, uint lvl)
 {
-uid next = 0;
-
-  do {
-       if( next ) {
-         child->latch = bt_pinlatch (bt, next);
-         bt_lockpage (BtLockDelete, child->latch);
-         bt_lockpage (BtLockWrite, child->latch);
-
-         if( child->pool = bt_pinpool (bt, next) )
-               child->page = bt_page (bt, child->pool, next);
-         else
-               return bt->err;
-
-         child->page_no = next;
-       }
-
-       memcpy (root->page, child->page, bt->mgr->page_size);
-       next = bt_getid (slotptr(child->page, child->page->cnt)->id);
-       bt_freepage (bt, child);
-  } while( root->page->lvl > 1 && root->page->cnt == 1 );
-
-  bt_unlockpage (BtLockWrite, root->latch);
-  bt_unpinlatch (root->latch);
-  bt_unpinpool (root->pool);
-  return 0;
-}
+unsigned char leftkey[256], rightkey[256];
+uid page_no;
+BtKey ptr;
 
-//  pull right page over ourselves in simple merge
+       //      remove the old fence value
 
-BTERR bt_mergeright (BtDb *bt, BtPageSet *set, BtPageSet *parent, BtPageSet *right, uint slot, uint idx)
-{
-       //  install ourselves as child page
-       //      and delete ourselves from parent
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (rightkey, ptr, ptr->len + 1);
 
-       bt_putid (slotptr(parent->page, idx)->id, set->page_no);
-       slotptr(parent->page, slot)->dead = 1;
-       parent->page->act--;
+       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+       set->page->dirty = 1;
 
-       //      collapse any empty slots
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (leftkey, ptr, ptr->len + 1);
+       page_no = set->page_no;
 
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, idx + 1);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
+       bt_lockpage (BtLockParent, set->latch);
+       bt_unlockpage (BtLockWrite, set->latch);
 
-       memcpy (set->page, right->page, bt->mgr->page_size);
-       bt_unlockpage (BtLockParent, right->latch);
+       //      insert new (now smaller) fence key
 
-       bt_freepage (bt, right);
+       if( bt_insertkey (bt, leftkey+1, *leftkey, lvl+1, page_no, time(NULL)) )
+         return bt->err;
 
-       //      do we need to remove a btree level?
-       //      (leave the first page of leaves alone)
+       //      now delete old fence key
 
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-         if( set->page->lvl )
-               return bt_removeroot (bt, parent, set);
+       if( bt_deletekey (bt, rightkey+1, *rightkey, lvl+1) )
+               return bt->err;
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unlockpage (BtLockDelete, set->latch);
-       bt_unlockpage (BtLockWrite, set->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
-       bt_unpinlatch (set->latch);
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch(set->latch);
        bt_unpinpool (set->pool);
        return 0;
 }
 
-//     remove both child and parent from the btree
-//     from the fence position in the parent
-//     call with both pages locked for writing
+//     root has a single child
+//     collapse a level from the tree
 
-BTERR bt_removeparent (BtDb *bt, BtPageSet *child, BtPageSet *parent, BtPageSet *right, BtPageSet *rparent, uint lvl)
+BTERR bt_collapseroot (BtDb *bt, BtPageSet *root)
 {
-unsigned char pagefence[256];
+BtPageSet child[1];
 uint idx;
 
-       //  pull right sibling over ourselves and unlock
-
-       memcpy (child->page, right->page, bt->mgr->page_size);
-
-       bt_unlockpage (BtLockWrite, child->latch);
-       bt_unpinlatch (child->latch);
-       bt_unpinpool (child->pool);
-
-       //  install ourselves into right link of old right page
-
-       bt_putid (right->page->right, child->page_no);
-       right->page->goright = 1;       // tell bt_loadpage to go right to us
-       right->page->kill = 1;
-
-       bt_unlockpage (BtLockWrite, right->latch);
-
-       //      remove our slot from our parent
-       //      signal to move right
-
-       parent->page->goright = 1;      // tell bt_loadpage to go right to rparent
-       parent->page->kill = 1;
-       parent->page->act--;
-
-       //      redirect right page pointer in right parent to us
+  // find the child entry and promote as new root contents
 
-       for( idx = 0; idx++ < rparent->page->cnt; )
-         if( !slotptr(rparent->page, idx)->dead )
+  do {
+       for( idx = 0; idx++ < root->page->cnt; )
+         if( !slotptr(root->page, idx)->dead )
                break;
 
-       if( bt_getid (slotptr(rparent->page, idx)->id) != right->page_no )
-               return bt->err = BTERR_struct;
+       child->page_no = bt_getid (slotptr(root->page, idx)->id);
 
-       bt_putid (slotptr(rparent->page, idx)->id, child->page_no);
-       bt_unlockpage (BtLockWrite, rparent->latch);
-       bt_unpinlatch (rparent->latch);
-       bt_unpinpool (rparent->pool);
+       child->latch = bt_pinlatch (bt, child->page_no);
+       bt_lockpage (BtLockDelete, child->latch);
+       bt_lockpage (BtLockWrite, child->latch);
 
-       //      free the right page
-
-       bt_lockpage (BtLockDelete, right->latch);
-       bt_lockpage (BtLockWrite, right->latch);
-       bt_freepage (bt, right);
+       if( child->pool = bt_pinpool (bt, child->page_no) )
+               child->page = bt_page (bt, child->pool, child->page_no);
+       else
+               return bt->err;
 
-       //      save parent page fence value
+       memcpy (root->page, child->page, bt->mgr->page_size);
+       bt_freepage (bt, child);
 
-       memcpy (pagefence, parent->page->fence, 256);
-       bt_unlockpage (BtLockWrite, parent->latch);
+  } while( root->page->lvl > 1 && root->page->act == 1 );
 
-       return bt_removepage (bt, parent, lvl, pagefence);
+  bt_unlockpage (BtLockWrite, root->latch);
+  bt_unpinlatch (root->latch);
+  bt_unpinpool (root->pool);
+  return 0;
 }
 
-//     remove page from btree
-//     call with page unlocked
-//     returns with page on free list
+//  find and delete key on page by marking delete flag bit
+//  if page becomes empty, delete it from the btree
 
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence)
+BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl)
 {
-BtPageSet parent[1], sibling[1], rparent[1];
-unsigned char newfence[256];
-uint slot, idx;
+unsigned char lowerfence[256], higherfence[256];
+uint slot, idx, dirty = 0, fence, found;
+BtPageSet set[1], right[1];
 BtKey ptr;
 
-       //      load and lock our parent
-
-  while( 1 ) {
-       if( !(slot = bt_loadpage (bt, parent, pagefence+1, *pagefence, lvl+1, BtLockWrite)) )
+       if( slot = bt_loadpage (bt, set, key, len, lvl, BtLockWrite) )
+               ptr = keyptr(set->page, slot);
+       else
                return bt->err;
 
-       //      do we show up in our parent yet?
-
-       if( set->page_no != bt_getid (slotptr (parent->page, slot)->id) ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-
-       //      can we do a simple merge entirely
-       //      between siblings on the parent page?
-
-       if( slot < parent->page->cnt ) {
-               // find our right neighbor
-               //      right must exist because the stopper prevents
-               //      the rightmost page from deleting
-
-               for( idx = slot; idx++ < parent->page->cnt; )
-                 if( !slotptr(parent->page, idx)->dead )
-                       break;
-
-               sibling->page_no = bt_getid (slotptr (parent->page, idx)->id);
-
-               bt_lockpage (BtLockDelete, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-
-               //      merge right if sibling shows up in
-               //  our parent and is not being killed
-
-               if( sibling->page_no == bt_getid (set->page->right) ) {
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-                 bt_lockpage (BtLockParent, sibling->latch);
-                 bt_lockpage (BtLockDelete, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
+       //      are we deleting a fence slot?
 
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_mergeright(bt, set, parent, sibling, slot, idx);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockParent, sibling->latch);
-                 bt_unlockpage (BtLockDelete, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
-
-               bt_unlockpage (BtLockDelete, set->latch);
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
+       fence = slot == set->page->cnt;
 
-       //  find our left neighbor in our parent page
-
-       for( idx = slot; --idx; )
-         if( !slotptr(parent->page, idx)->dead )
-               break;
-
-       //      if no left neighbor, delete ourselves and our parent
-
-       if( !idx ) {
-               bt_lockpage (BtLockAccess, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockAccess, set->latch);
-
-               rparent->page_no = bt_getid (parent->page->right);
-               rparent->latch = bt_pinlatch (bt, rparent->page_no);
-
-               bt_lockpage (BtLockAccess, rparent->latch);
-               bt_lockpage (BtLockWrite, rparent->latch);
-               bt_unlockpage (BtLockAccess, rparent->latch);
-
-               if( rparent->pool = bt_pinpool (bt, rparent->page_no) )
-                       rparent->page = bt_page (bt, rparent->pool, rparent->page_no);
-               else
-                       return bt->err;
-
-               if( !rparent->page->kill ) {
-                 sibling->page_no = bt_getid (set->page->right);
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-
-                 bt_lockpage (BtLockAccess, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockAccess, sibling->latch);
-
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_removeparent (bt, set, parent, sibling, rparent, lvl+1);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
+       // if key is found delete it, otherwise ignore request
 
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, rparent->latch);
-               bt_unpinlatch (rparent->latch);
-               bt_unpinpool (rparent->pool);
+       if( found = !keycmp (ptr, key, len) )
+         if( found = slotptr(set->page, slot)->dead == 0 ) {
+               dirty = slotptr(set->page, slot)->dead = 1;
+               set->page->dirty = 1;
+               set->page->act--;
 
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
+               // collapse empty slots
 
-       // redirect parent to our left sibling
-       // lock and map our left sibling's page
+               while( idx = set->page->cnt - 1 )
+                 if( slotptr(set->page, idx)->dead ) {
+                       *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
+                       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+                 } else
+                       break;
+                 }
 
-       sibling->page_no = bt_getid (slotptr(parent->page, idx)->id);
-       sibling->latch = bt_pinlatch (bt, sibling->page_no);
+       //      did we delete a fence key in an upper level?
 
-       //      wait our turn on fence key maintenance
+       if( dirty && lvl && set->page->act && fence )
+         if( bt_fixfence (bt, set, lvl) )
+               return bt->err;
+         else
+               return bt->found = found, 0;
 
-       bt_lockpage(BtLockParent, sibling->latch);
-       bt_lockpage(BtLockAccess, sibling->latch);
-       bt_lockpage(BtLockWrite, sibling->latch);
-       bt_unlockpage(BtLockAccess, sibling->latch);
+       //      is this a collapsed root?
 
-       if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-       else
+       if( lvl > 1 && set->page_no == ROOT_page && set->page->act == 1 )
+         if( bt_collapseroot (bt, set) )
                return bt->err;
+         else
+               return bt->found = found, 0;
 
-       //  wait until left sibling is in our parent
+       //      return if page is not empty
 
-       if( bt_getid (sibling->page->right) != set->page_no ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unlockpage (BtLockWrite, sibling->latch);
-               bt_unlockpage (BtLockParent, sibling->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-               bt_unpinlatch (sibling->latch);
-               bt_unpinpool (sibling->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
+       if( set->page->act ) {
+               bt_unlockpage(BtLockWrite, set->latch);
+               bt_unpinlatch (set->latch);
+               bt_unpinpool (set->pool);
+               return bt->found = found, 0;
        }
 
-       //      delete our left sibling from parent
+       //      cache copy of fence key
+       //      to post in parent
 
-       slotptr(parent->page,idx)->dead = 1;
-       parent->page->dirty = 1;
-       parent->page->act--;
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (lowerfence, ptr, ptr->len + 1);
 
-       //      redirect our parent slot to our left sibling
+       //      obtain lock on right page
 
-       bt_putid (slotptr(parent->page, slot)->id, sibling->page_no);
-       memcpy (sibling->page->right, set->page->right, BtId);
-
-       //      collapse dead slots from parent
-
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, parent->page->cnt);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
-
-       //  free our original page
-
-       bt_lockpage (BtLockDelete, set->latch);
-       bt_lockpage (BtLockWrite, set->latch);
-       bt_freepage (bt, set);
-
-       //      go down the left node's fence keys to the leaf level
-       //      and update the fence keys in each page
-
-       memcpy (newfence, parent->page->fence, 256);
-
-       if( bt_fixfences (bt, sibling, newfence) )
-               return bt->err;
+       right->page_no = bt_getid(set->page->right);
+       right->latch = bt_pinlatch (bt, right->page_no);
+       bt_lockpage (BtLockWrite, right->latch);
 
-       //  promote sibling as new root?
+       // pin page contents
 
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-        if( sibling->page->lvl ) {
-         sibling->latch = bt_pinlatch (bt, sibling->page_no);
-         bt_lockpage (BtLockDelete, sibling->latch);
-         bt_lockpage (BtLockWrite, sibling->latch);
+       if( right->pool = bt_pinpool (bt, right->page_no) )
+               right->page = bt_page (bt, right->pool, right->page_no);
+       else
+               return 0;
 
-         if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-         else
-               return bt->err;
+       if( right->page->kill )
+               return bt->err = BTERR_struct;
 
-         return bt_removeroot (bt, parent, sibling);
-        }
+       // pull contents of right peer into our empty page
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
+       memcpy (set->page, right->page, bt->mgr->page_size);
 
-       return 0;
-  }
-}
+       // cache copy of key to update
 
-//  find and delete key on page by marking delete flag bit
-//  if page becomes empty, delete it from the btree
+       ptr = keyptr(right->page, right->page->cnt);
+       memcpy (higherfence, ptr, ptr->len + 1);
 
-BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len)
-{
-unsigned char pagefence[256];
-uint slot, idx, found;
-BtPageSet set[1];
-BtKey ptr;
+       // mark right page deleted and point it to left page
+       //      until we can post parent updates
 
-       if( slot = bt_loadpage (bt, set, key, len, 0, BtLockWrite) )
-               ptr = keyptr(set->page, slot);
-       else
-               return bt->err;
+       bt_putid (right->page->right, set->page_no);
+       right->page->kill = 1;
 
-       // if key is found delete it, otherwise ignore request
+       bt_lockpage (BtLockParent, right->latch);
+       bt_unlockpage (BtLockWrite, right->latch);
 
-       if( found = slot <= set->page->cnt )
-         if( found = !keycmp (ptr, key, len) )
-               if( found = slotptr(set->page, slot)->dead == 0 ) {
-                 slotptr(set->page,slot)->dead = 1;
-                 set->page->dirty = 1;
-                 set->page->act--;
+       bt_lockpage (BtLockParent, set->latch);
+       bt_unlockpage (BtLockWrite, set->latch);
 
-                 // collapse empty slots
+       // redirect higher key directly to our new node contents
 
-                 while( idx = set->page->cnt - 1 )
-                       if( slotptr(set->page, idx)->dead ) {
-                         *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
-                         memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
-                       } else
-                               break;
-               }
+       if( bt_insertkey (bt, higherfence+1, *higherfence, lvl+1, set->page_no, time(NULL)) )
+         return bt->err;
 
-       if( set->page->act ) {
-               bt_unlockpage(BtLockWrite, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               return bt->found = found, 0;
-       }
+       //      delete old lower key to our node
 
-       memcpy (pagefence, set->page->fence, 256);
-       set->page->kill = 1;
+       if( bt_deletekey (bt, lowerfence+1, *lowerfence, lvl+1) )
+         return bt->err;
 
-       bt_unlockpage (BtLockWrite, set->latch);
+       //      obtain delete and write locks to right node
 
-       if( bt_removepage (bt, set, 0, pagefence) )
-               return bt->err;
+       bt_unlockpage (BtLockParent, right->latch);
+       bt_lockpage (BtLockDelete, right->latch);
+       bt_lockpage (BtLockWrite, right->latch);
+       bt_freepage (bt, right);
 
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch (set->latch);
+       bt_unpinpool (set->pool);
        bt->found = found;
        return 0;
 }
@@ -2165,7 +1852,7 @@ BtKey ptr;
 
 uint bt_cleanpage(BtDb *bt, BtPage page, uint amt, uint slot)
 {
-uint nxt = bt->mgr->page_size, off;
+uint nxt = bt->mgr->page_size;
 uint cnt = 0, idx = 0;
 uint max = page->cnt;
 uint newslot = max;
@@ -2193,26 +1880,22 @@ BtKey key;
        while( cnt++ < max ) {
                if( cnt == slot )
                        newslot = idx + 1;
-               if( slotptr(bt->frame,cnt)->dead )
+               if( cnt < max && slotptr(bt->frame,cnt)->dead )
                        continue;
 
-               // if its not the fence key,
                // copy the key across
 
-               off = slotptr(bt->frame,cnt)->off;
-
-               if( off >= sizeof(*page) ) {
-                       key = keyptr(bt->frame, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)page + nxt, key, key->len + 1);
-               }
+               key = keyptr(bt->frame, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)page + nxt, key, key->len + 1);
 
                // copy slot
 
                memcpy(slotptr(page, ++idx)->id, slotptr(bt->frame, cnt)->id, BtId);
+               if( !(slotptr(page, idx)->dead = slotptr(bt->frame, cnt)->dead) )
+                       page->act++;
                slotptr(page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(page, idx)->off = off;
-               page->act++;
+               slotptr(page, idx)->off = nxt;
        }
 
        page->min = nxt;
@@ -2228,42 +1911,38 @@ BtKey key;
 
 // split the root and raise the height of the btree
 
-BTERR bt_splitroot(BtDb *bt, BtPageSet *root, uid page_no2)
+BTERR bt_splitroot(BtDb *bt, BtPageSet *root, unsigned char *leftkey, uid page_no2)
 {
 uint nxt = bt->mgr->page_size;
-unsigned char leftkey[256];
-uid new_page;
+uid left;
 
        //  Obtain an empty page to use, and copy the current
        //  root contents into it, e.g. lower keys
 
-       memcpy (leftkey, root->page->fence, 256);
-       root->page->posted = 1;
-
-       if( !(new_page = bt_newpage(bt, root->page)) )
+       if( !(left = bt_newpage(bt, root->page)) )
                return bt->err;
 
        // preserve the page info at the bottom
        // of higher keys and set rest to zero
 
        memset(root->page+1, 0, bt->mgr->page_size - sizeof(*root->page));
-       memset(root->page->fence, 0, 256);
-       root->page->fence[0] = 2;
-       root->page->fence[1] = 0xff;
-       root->page->fence[2] = 0xff;
 
-       // insert lower keys page fence key on newroot page
+       // insert lower keys page fence key on newroot page as first key
 
        nxt -= *leftkey + 1;
        memcpy ((unsigned char *)root->page + nxt, leftkey, *leftkey + 1);
-       bt_putid(slotptr(root->page, 1)->id, new_page);
+       bt_putid(slotptr(root->page, 1)->id, left);
        slotptr(root->page, 1)->off = nxt;
        
        // insert stopper key on newroot page
        // and increase the root height
 
+       nxt -= 3;
+       ((unsigned char *)root->page)[nxt] = 2;
+       ((unsigned char *)root->page)[nxt+1] = 0xff;
+       ((unsigned char *)root->page)[nxt+2] = 0xff;
        bt_putid(slotptr(root->page, 2)->id, page_no2);
-       slotptr(root->page, 2)->off = offsetof(struct BtPage_, fence);
+       slotptr(root->page, 2)->off = nxt;
 
        bt_putid(root->page->right, 0);
        root->page->min = nxt;          // reset lowest used offset and key count
@@ -2284,9 +1963,10 @@ uid new_page;
 
 BTERR bt_splitpage (BtDb *bt, BtPageSet *set)
 {
-uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size, off;
+uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size;
 unsigned char fencekey[256];
 uint lvl = set->page->lvl;
+uint prev;
 uid right;
 BtKey key;
 
@@ -2298,23 +1978,17 @@ BtKey key;
        idx = 0;
 
        while( cnt++ < max ) {
-               if( !lvl || cnt < max ) {
-                       key = keyptr(set->page, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
-               } else
-                       off = offsetof(struct BtPage_, fence);
+               key = keyptr(set->page, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
 
                memcpy(slotptr(bt->frame,++idx)->id, slotptr(set->page,cnt)->id, BtId);
+               if( !(slotptr(bt->frame, idx)->dead = slotptr(set->page, cnt)->dead) )
+                       bt->frame->act++;
                slotptr(bt->frame, idx)->tod = slotptr(set->page, cnt)->tod;
-               slotptr(bt->frame, idx)->off = off;
-               bt->frame->act++;
+               slotptr(bt->frame, idx)->off = nxt;
        }
 
-       if( set->page_no == ROOT_page )
-               bt->frame->posted = 1;
-
-       memcpy (bt->frame->fence, set->page->fence, 256);
        bt->frame->bits = bt->mgr->page_bits;
        bt->frame->min = nxt;
        bt->frame->cnt = idx;
@@ -2345,24 +2019,17 @@ BtKey key;
 
        while( cnt++ < max / 2 ) {
                key = keyptr(bt->frame, cnt);
-
-               if( !lvl || cnt < max / 2 ) {
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
-               } else 
-                       off = offsetof(struct BtPage_, fence);
-
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
                memcpy(slotptr(set->page,++idx)->id, slotptr(bt->frame,cnt)->id, BtId);
                slotptr(set->page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(set->page, idx)->off = off;
+               slotptr(set->page, idx)->off = nxt;
                set->page->act++;
        }
 
-       // install fence key for smaller key page
-
-       memset(set->page->fence, 0, 256);
-       memcpy(set->page->fence, key, key->len + 1);
+       // remember fence key for smaller page
 
+       memcpy(fencekey, key, key->len + 1);
        bt_putid(set->page->right, right);
        set->page->min = nxt;
        set->page->cnt = idx;
@@ -2370,20 +2037,20 @@ BtKey key;
        // if current page is the root page, split it
 
        if( set->page_no == ROOT_page )
-               return bt_splitroot (bt, set, right);
+               return bt_splitroot (bt, set, fencekey, right);
 
-       bt_unlockpage (BtLockWrite, set->latch);
+       right = 0;
 
        // insert new fences in their parent pages
 
        while( 1 ) {
                bt_lockpage (BtLockParent, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
 
-               memcpy (fencekey, set->page->fence, 256);
-               right = bt_getid (set->page->right);
+               key = keyptr (set->page, set->page->cnt);
+               memcpy (fencekey, key, key->len + 1);
+               prev = set->page->posted;
 
-               if( set->page->posted ) {
+               if( right && prev ) {
                        bt_unlockpage (BtLockParent, set->latch);
                        bt_unlockpage (BtLockWrite, set->latch);
                        bt_unpinlatch (set->latch);
@@ -2391,10 +2058,15 @@ BtKey key;
                        return 0;
                }
 
+               right = bt_getid (set->page->right);
                set->page->posted = 1;
+
                bt_unlockpage (BtLockWrite, set->latch);
 
-               if( bt_insertkey (bt, fencekey+1, *fencekey, set->page_no, time(NULL), lvl+1) )
+               // insert new fence for reformulated left block of smaller keys
+
+               if( !prev )
+                 if( bt_insertkey (bt, fencekey+1, *fencekey, lvl+1, set->page_no, time(NULL)) )
                        return bt->err;
 
                bt_unlockpage (BtLockParent, set->latch);
@@ -2410,6 +2082,8 @@ BtKey key;
                        set->page = bt_page (bt, set->pool, right);
                else
                        return bt->err;
+
+               bt_lockpage (BtLockWrite, set->latch);
        }
 
        return 0;
@@ -2417,7 +2091,7 @@ BtKey key;
 
 //  Insert new key into the btree at given level.
 
-BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl)
+BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod)
 {
 BtPageSet set[1];
 uint slot, idx;
@@ -2435,8 +2109,7 @@ BtKey ptr;
 
                // if key already exists, update id and return
 
-               if( slot <= set->page->cnt )
-                 if( !keycmp (ptr, key, len) ) {
+               if( !keycmp (ptr, key, len) ) {
                        if( slotptr(set->page, slot)->dead )
                                set->page->act++;
                        slotptr(set->page, slot)->dead = 0;
@@ -2463,14 +2136,14 @@ BtKey ptr;
        ((unsigned char *)set->page)[set->page->min] = len;
        memcpy ((unsigned char *)set->page + set->page->min +1, key, len );
 
-       for( idx = slot; idx <= set->page->cnt; idx++ )
+       for( idx = slot; idx < set->page->cnt; idx++ )
          if( slotptr(set->page, idx)->dead )
                break;
 
        // now insert key into array before slot
 
-       if( idx > set->page->cnt )
-               set->page->cnt++;
+       if( idx == set->page->cnt )
+               idx++, set->page->cnt++;
 
        set->page->act++;
 
@@ -2520,6 +2193,7 @@ uid right;
 
   do {
        right = bt_getid(bt->cursor->right);
+
        while( slot++ < bt->cursor->cnt )
          if( slotptr(bt->cursor,slot)->dead )
                continue;
@@ -2547,6 +2221,7 @@ uid right;
        bt_unpinlatch (set->latch);
        bt_unpinpool (set->pool);
        slot = 0;
+
   } while( 1 );
 
   return bt->err = 0;
@@ -2573,7 +2248,9 @@ uint bt_tod(BtDb *bt, uint slot)
 void bt_latchaudit (BtDb *bt)
 {
 ushort idx, hashidx;
+uid next, page_no;
 BtPageSet set[1];
+BtKey ptr;
 
 #ifdef unix
        for( idx = 1; idx < bt->mgr->latchmgr->latchdeployed; idx++ ) {
@@ -2594,18 +2271,21 @@ BtPageSet set[1];
          } while( idx = set->latch->next );
        }
 
-       set->page_no = bt_getid(bt->mgr->latchmgr->alloc[1].right);
-
-       while( set->page_no ) {
-               fprintf(stderr, "free: %.6x\n", (uint)set->page_no);
-
-               if( set->pool = bt_pinpool (bt, set->page_no) )
-                       set->page = bt_page (bt, set->pool, set->page_no);
-               else
-                       return;
-
-           set->page_no = bt_getid(set->page->right);
-               bt_unpinpool (set->pool);
+       next = bt->mgr->latchmgr->nlatchpage + LATCH_page;
+       page_no = LEAF_page;
+
+       while( page_no < bt_getid(bt->mgr->latchmgr->alloc->right) ) {
+               pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, page_no << bt->mgr->page_bits);
+               if( !bt->frame->free )
+                for( idx = 0; idx++ < bt->frame->cnt - 1; ) {
+                 ptr = keyptr(bt->frame, idx+1);
+                 if( keycmp (keyptr(bt->frame, idx), ptr->key, ptr->len) >= 0 )
+                       fprintf(stderr, "page %.8x idx %.2x out of order\n", page_no, idx);
+                }
+
+               if( page_no > LEAF_page )
+                       next = page_no + 1;
+               page_no = next;
        }
 #endif
 }
@@ -2662,7 +2342,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_insertkey (bt, key, len, line, *tod, 0) )
+                         if( bt_insertkey (bt, key, len, 0, line, *tod) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2684,7 +2364,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_deletekey (bt, key, len) )
+                         if( bt_deletekey (bt, key, len, 0) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2710,6 +2390,8 @@ FILE *in;
                                found++;
                          else if( bt->err )
                                fprintf(stderr, "Error %d Syserr %d Line: %d\n", bt->err, errno, line), exit(0);
+                         else
+                               fprintf(stderr, "Unable to find key %.*s line %d\n", len, key, line);
                          len = 0;
                        }
                        else if( len < 255 )
@@ -2752,7 +2434,20 @@ FILE *in;
                page_no = LEAF_page;
 
                while( page_no < bt_getid(bt->mgr->latchmgr->alloc->right) ) {
-                       pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, page_no << bt->mgr->page_bits);
+               uid off = page_no << bt->mgr->page_bits;
+#ifdef unix
+                 pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, off);
+#else
+               DWORD amt[1];
+
+                 SetFilePointer (bt->mgr->idx, (long)off, (long*)(&off)+1, FILE_BEGIN);
+
+                 if( !ReadFile(bt->mgr->idx, bt->frame, bt->mgr->page_size, amt, NULL))
+                       return bt->err = BTERR_map;
+
+                 if( *amt <  bt->mgr->page_size )
+                       return bt->err = BTERR_map;
+#endif
                        if( !bt->frame->free && !bt->frame->lvl )
                                cnt += bt->frame->act;
                        if( page_no > LEAF_page )
index 309ecaf8a505e0b73b604529ab7a92ed2326bd7f..0c7c41d43896023485e29cab0f96a3ad30b640c9 100644 (file)
@@ -1,6 +1,6 @@
 // btree version threads2i sched_yield version
 //     with reworked bt_deletekey code
-// 12 FEB 2014
+// 17 FEB 2014
 
 // author: karl malbrain, malbrain@cal.berkeley.edu
 
@@ -87,24 +87,17 @@ typedef enum{
        BtLockParent
 } BtLock;
 
-//     mode & definition for latch implementation
-
-enum {
-       Mutex = 1,
-       Write = 2,
-       Pending = 4,
-       Share = 8
-} LockMode;
+//     definition for latch implementation
 
 // exclusive is set for write access
 // share is count of read accessors
 // grant write lock when share == 0
 
 typedef struct {
-       volatile ushort mutex:1;
-       volatile ushort exclusive:1;
-       volatile ushort pending:1;
-       volatile ushort share:13;
+       volatile unsigned char mutex;
+       volatile unsigned char exclusive:1;
+       volatile unsigned char pending:1;
+       volatile ushort share;
 } BtSpinLatch;
 
 //  hash table entries
@@ -151,7 +144,7 @@ typedef struct {
 } BtSlot;
 
 //     The key structure occupies space at the upper end of
-//     each page.  It's a length byte followed by the value
+//     each page.  It's a length byte followed by the key
 //     bytes.
 
 typedef struct {
@@ -169,13 +162,11 @@ typedef struct BtPage_ {
        uint min;                                       // next key offset
        unsigned char bits:7;           // page size in bits
        unsigned char free:1;           // page is on free chain
-       unsigned char lvl:4;            // level of page
+       unsigned char lvl:5;            // level of page
        unsigned char kill:1;           // page is being deleted
        unsigned char dirty:1;          // page has deleted keys
        unsigned char posted:1;         // page fence is posted
-       unsigned char goright:1;        // page is being deleted, go right
        unsigned char right[BtId];      // page number to right
-       unsigned char fence[256];       // page fence key
 } *BtPage;
 
 //     The memory mapping pool table buffer manager entry
@@ -266,15 +257,12 @@ typedef enum {
 // B-Tree functions
 extern void bt_close (BtDb *bt);
 extern BtDb *bt_open (BtMgr *mgr);
-extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl);
-extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len);
+extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod);
+extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl);
 extern uid bt_findkey    (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_startkey  (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_nextkey   (BtDb *bt, uint slot);
 
-//     internal functions
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence);
-
 //     manager functions
 extern BtMgr *bt_mgr (char *name, uint mode, uint bits, uint poolsize, uint segsize, uint hashsize);
 void bt_mgrclose (BtMgr *mgr);
@@ -304,7 +292,8 @@ extern uint bt_tod (BtDb *bt, uint slot);
 //  A key consists of a length byte, two bytes of
 //  index number (0 - 65534), and up to 253 bytes
 //  of key value.  Duplicate keys are discarded.
-//  Associated with each key is a 48 bit row-id.
+//  Associated with each key is a 48 bit row-id,
+//     or any other value desired.
 
 //  The b-tree root is always located at page 1.
 //     The first leaf page of level zero is always
@@ -320,7 +309,7 @@ extern uint bt_tod (BtDb *bt, uint slot);
 
 //     Deleted keys are marked with a dead bit until
 //     page cleanup. The fence key for a node is
-//     present in a special array
+//     always present
 
 //  Groups of pages called segments from the btree are optionally
 //  cached with a memory mapped pool. A hash table is used to keep
@@ -377,29 +366,26 @@ ushort prev;
   do {
        //      obtain latch mutex
 #ifdef unix
-       if( __sync_fetch_and_or((ushort *)latch, Mutex) & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                continue;
 #else
-       if( prev = _InterlockedOr16((ushort *)latch, Mutex) & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                continue;
 #endif
        //  see if exclusive request is granted or pending
 
        if( prev = !(latch->exclusive | latch->pending) )
-#ifdef unix
-               __sync_fetch_and_add((ushort *)latch, Share);
-#else
-               _InterlockedExchangeAdd16 ((ushort *)latch, Share);
-#endif
+               latch->share++;
 
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 
        if( prev )
                return;
+
 #ifdef  unix
   } while( sched_yield(), 1 );
 #else
@@ -411,31 +397,27 @@ ushort prev;
 
 void bt_spinwritelock(BtSpinLatch *latch)
 {
+uint prev;
+
   do {
 #ifdef  unix
-       if( __sync_fetch_and_or((ushort *)latch, Mutex | Pending) & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                continue;
 #else
-       if( _InterlockedOr16((ushort *)latch, Mutex | Pending) & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                continue;
 #endif
-       if( !(latch->share | latch->exclusive) ) {
+       if( prev = !(latch->share | latch->exclusive) )
+               latch->exclusive = 1, latch->pending = 0;
+       else
+               latch->pending = 1;
 #ifdef unix
-               __sync_fetch_and_or((ushort *)latch, Write);
-               __sync_fetch_and_and ((ushort *)latch, ~(Mutex | Pending));
+       __sync_lock_release (&latch->mutex);
 #else
-               _InterlockedOr16((ushort *)latch, Write);
-               _InterlockedAnd16((ushort *)latch, ~(Mutex | Pending));
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
+       if( prev )
                return;
-       }
-
-#ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
-#else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
-#endif
-
 #ifdef  unix
   } while( sched_yield(), 1 );
 #else
@@ -450,30 +432,26 @@ void bt_spinwritelock(BtSpinLatch *latch)
 
 int bt_spinwritetry(BtSpinLatch *latch)
 {
-ushort prev;
+uint prev;
 
 #ifdef unix
-       if( prev = __sync_fetch_and_or((ushort *)latch, Mutex), prev & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                return 0;
 #else
-       if( prev = _InterlockedOr16((ushort *)latch, Mutex), prev & Mutex )
+       if( _InterlockedExchange8(&latch->mutex, 1) )
                return 0;
 #endif
        //      take write access if all bits are clear
 
-       if( !prev )
-#ifdef unix
-               __sync_fetch_and_or ((ushort *)latch, Write);
-#else
-               _InterlockedOr16((ushort *)latch, Write);
-#endif
+       if( prev = !(latch->exclusive | latch->share) )
+               latch->exclusive = 1;
 
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedAnd16((ushort *)latch, ~Mutex);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
-       return !prev;
+       return prev;
 }
 
 //     clear write mode
@@ -481,9 +459,17 @@ ushort prev;
 void bt_spinreleasewrite(BtSpinLatch *latch)
 {
 #ifdef unix
-       __sync_fetch_and_and ((ushort *)latch, ~Write);
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
+               sched_yield();
+#else
+       while( _InterlockedExchange8(&latch->mutex, 1) )
+               SwitchToThread();
+#endif
+       latch->exclusive = 0;
+#ifdef unix
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedAnd16((ushort *)latch, ~Write);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 }
 
@@ -492,9 +478,17 @@ void bt_spinreleasewrite(BtSpinLatch *latch)
 void bt_spinreleaseread(BtSpinLatch *latch)
 {
 #ifdef unix
-       __sync_fetch_and_add((ushort *)latch, -Share);
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
+               sched_yield();
+#else
+       while( _InterlockedExchange8(&latch->mutex, 1) )
+               SwitchToThread();
+#endif
+       latch->share--;
+#ifdef unix
+       __sync_lock_release (&latch->mutex);
 #else
-       _InterlockedExchangeAdd16 ((ushort *)latch, -Share);
+       _InterlockedExchange8(&latch->mutex, 0);
 #endif
 }
 
@@ -882,12 +876,13 @@ SYSTEM_INFO sysinfo[1];
        latchmgr->alloc->bits = mgr->page_bits;
 
        for( lvl=MIN_lvl; lvl--; ) {
-               slotptr(latchmgr->alloc, 1)->off = offsetof(struct BtPage_, fence);
+               slotptr(latchmgr->alloc, 1)->off = mgr->page_size - 3;
                bt_putid(slotptr(latchmgr->alloc, 1)->id, lvl ? MIN_lvl - lvl + 1 : 0);         // next(lower) page number
-               latchmgr->alloc->fence[0] = 2;                  // create stopper key
-               latchmgr->alloc->fence[1] = 0xff;
-               latchmgr->alloc->fence[2] = 0xff;
-               latchmgr->alloc->min = mgr->page_size;
+               key = keyptr(latchmgr->alloc, 1);
+               key->len = 2;           // create stopper key
+               key->key[0] = 0xff;
+               key->key[1] = 0xff;
+               latchmgr->alloc->min = mgr->page_size - 3;
                latchmgr->alloc->lvl = lvl;
                latchmgr->alloc->cnt = 1;
                latchmgr->alloc->act = 1;
@@ -1080,7 +1075,7 @@ int flag;
 
 #ifdef unix
        flag = PROT_READ | ( bt->mgr->mode == BT_ro ? 0 : PROT_WRITE );
-       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED | MAP_POPULATE, bt->mgr->idx, off);
+       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED, bt->mgr->idx, off);
        if( pool->map == MAP_FAILED )
                return bt->err = BTERR_map;
 
@@ -1373,44 +1368,38 @@ int reuse;
 int bt_findslot (BtPageSet *set, unsigned char *key, uint len)
 {
 uint diff, higher = set->page->cnt, low = 1, slot;
+uint good = 0;
 
        //        make stopper key an infinite fence value
 
        if( bt_getid (set->page->right) )
                higher++;
+       else
+               good++;
 
        //      low is the lowest candidate.
        //  loop ends when they meet
 
        //  higher is already
-       //      tested as .ge. the given key.
+       //      tested as .ge. the passed key.
 
        while( diff = higher - low ) {
                slot = low + ( diff >> 1 );
                if( keycmp (keyptr(set->page, slot), key, len) < 0 )
                        low = slot + 1;
                else
-                       higher = slot;
+                       higher = slot, good++;
        }
 
-       if( higher <= set->page->cnt )
-               return higher;
-
-       //      if leaf page, compare against fence value
-
        //      return zero if key is on right link page
-       //      or return slot beyond last key
-
-       if( set->page->lvl || keycmp ((BtKey)set->page->fence, key, len) < 0 )
-               return 0;
 
-       return higher;
+       return good ? higher : 0;
 }
 
 //  find and load page at given level for given key
 //     leave page rd or wr locked as requested
 
-int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, uint lock)
+int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, BtLock lock)
 {
 uid page_no = ROOT_page, prevpage = 0;
 uint drill = 0xff, slot;
@@ -1422,7 +1411,7 @@ BtPool *prevpool;
 
   do {
        // determine lock mode of drill level
-       mode = (lock == BtLockWrite) && (drill == lvl) ? BtLockWrite : BtLockRead; 
+       mode = (drill == lvl) ? lock : BtLockRead; 
 
        set->latch = bt_pinlatch (bt, page_no);
        set->page_no = page_no;
@@ -1452,6 +1441,9 @@ BtPool *prevpool;
 
        bt_lockpage(mode, set->latch);
 
+       if( set->page->free )
+               return bt->err = BTERR_struct, 0;
+
        if( page_no > ROOT_page )
          bt_unlockpage(BtLockAccess, set->latch);
 
@@ -1463,7 +1455,7 @@ BtPool *prevpool;
                        
                drill = set->page->lvl;
 
-               if( lock == BtLockWrite && drill == lvl ) {
+               if( lock != BtLockRead && drill == lvl ) {
                  bt_unlockpage(mode, set->latch);
                  bt_unpinlatch (set->latch);
                  bt_unpinpool (set->pool);
@@ -1476,53 +1468,28 @@ BtPool *prevpool;
        prevpool = set->pool;
        prevmode = mode;
 
-       //      if page is being deleted and we should continue right
-
-       if( set->page->kill && set->page->goright ) {
-               page_no = bt_getid (set->page->right);
-               continue;
-       }
-
-       //      otherwise, wait for deleted node to clear
-
-       if( set->page->kill ) {
-               bt_unlockpage(mode, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               page_no = ROOT_page;
-               prevpage = 0;
-               drill = 0xff;
-#ifdef unix
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-       
        //  find key on page at this level
        //  and descend to requested level
 
-       if( slot = bt_findslot (set, key, len) ) {
+       if( !set->page->kill )
+        if( slot = bt_findslot (set, key, len) ) {
          if( drill == lvl )
                return slot;
 
-         if( slot > set->page->cnt )
-               return bt->err = BTERR_struct;
-
          while( slotptr(set->page, slot)->dead )
                if( slot++ < set->page->cnt )
                        continue;
                else
-                       return bt->err = BTERR_struct, 0;
+                       goto slideright;
 
          page_no = bt_getid(slotptr(set->page, slot)->id);
          drill--;
          continue;
-       }
+        }
 
        //  or slide right into next page
 
+slideright:
        page_no = bt_getid(set->page->right);
 
   } while( page_no );
@@ -1533,61 +1500,6 @@ BtPool *prevpool;
   return 0;    // return error
 }
 
-// drill down fixing fence values for left sibling tree
-
-//  call with set write locked
-//     return with set unlocked & unpinned.
-
-BTERR bt_fixfences (BtDb *bt, BtPageSet *set, unsigned char *newfence)
-{
-unsigned char oldfence[256];
-BtPageSet next[1];
-int chk;
-
-  memcpy (oldfence, set->page->fence, 256);
-  next->page_no = bt_getid(slotptr(set->page, set->page->cnt)->id);
-
-  while( !set->page->kill && set->page->lvl ) {
-       next->latch = bt_pinlatch (bt, next->page_no);
-       bt_lockpage (BtLockParent, next->latch);
-       bt_lockpage (BtLockAccess, next->latch);
-       bt_lockpage (BtLockWrite, next->latch);
-       bt_unlockpage (BtLockAccess, next->latch);
-
-       if( next->pool = bt_pinpool (bt, next->page_no) )
-               next->page = bt_page (bt, next->pool, next->page_no);
-       else
-               return bt->err;
-
-       chk = keycmp ((BtKey)next->page->fence, oldfence + 1, *oldfence);
-
-       if( chk < 0 ) {
-         next->page_no = bt_getid (next->page->right);
-         bt_unlockpage (BtLockWrite, next->latch);
-         bt_unlockpage (BtLockParent, next->latch);
-         bt_unpinlatch (next->latch);
-         bt_unpinpool (next->pool);
-         continue;
-       }
-
-       if( chk > 0 )
-               return bt->err = BTERR_struct;
-
-       if( bt_fixfences (bt, next, newfence) )
-               return bt->err;
-
-       break;
-  }
-
-  memcpy (set->page->fence, newfence, 256);
-
-  bt_unlockpage (BtLockWrite, set->latch);
-  bt_unlockpage (BtLockParent, set->latch);
-  bt_unpinlatch (set->latch);
-  bt_unpinpool (set->pool);
-  return 0;
-}
-
 //     return page to free list
 //     page must be delete & write locked
 
@@ -1614,434 +1526,208 @@ void bt_freepage (BtDb *bt, BtPageSet *set)
        bt_spinreleasewrite (bt->mgr->latchmgr->lock);
 }
 
-//     remove the root level by promoting its only child
-//     call with parent and child pages
+//     a fence key was deleted from a page
+//     push new fence value upwards
 
-BTERR bt_removeroot (BtDb *bt, BtPageSet *root, BtPageSet *child)
+BTERR bt_fixfence (BtDb *bt, BtPageSet *set, uint lvl)
 {
-uid next = 0;
-
-  do {
-       if( next ) {
-         child->latch = bt_pinlatch (bt, next);
-         bt_lockpage (BtLockDelete, child->latch);
-         bt_lockpage (BtLockWrite, child->latch);
-
-         if( child->pool = bt_pinpool (bt, next) )
-               child->page = bt_page (bt, child->pool, next);
-         else
-               return bt->err;
-
-         child->page_no = next;
-       }
-
-       memcpy (root->page, child->page, bt->mgr->page_size);
-       next = bt_getid (slotptr(child->page, child->page->cnt)->id);
-       bt_freepage (bt, child);
-  } while( root->page->lvl > 1 && root->page->cnt == 1 );
-
-  bt_unlockpage (BtLockWrite, root->latch);
-  bt_unpinlatch (root->latch);
-  bt_unpinpool (root->pool);
-  return 0;
-}
+unsigned char leftkey[256], rightkey[256];
+uid page_no;
+BtKey ptr;
 
-//  pull right page over ourselves in simple merge
+       //      remove the old fence value
 
-BTERR bt_mergeright (BtDb *bt, BtPageSet *set, BtPageSet *parent, BtPageSet *right, uint slot, uint idx)
-{
-       //  install ourselves as child page
-       //      and delete ourselves from parent
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (rightkey, ptr, ptr->len + 1);
 
-       bt_putid (slotptr(parent->page, idx)->id, set->page_no);
-       slotptr(parent->page, slot)->dead = 1;
-       parent->page->act--;
+       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+       set->page->dirty = 1;
 
-       //      collapse any empty slots
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (leftkey, ptr, ptr->len + 1);
+       page_no = set->page_no;
 
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, idx + 1);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
+       bt_lockpage (BtLockParent, set->latch);
+       bt_unlockpage (BtLockWrite, set->latch);
 
-       memcpy (set->page, right->page, bt->mgr->page_size);
-       bt_unlockpage (BtLockParent, right->latch);
+       //      insert new (now smaller) fence key
 
-       bt_freepage (bt, right);
+       if( bt_insertkey (bt, leftkey+1, *leftkey, lvl+1, page_no, time(NULL)) )
+         return bt->err;
 
-       //      do we need to remove a btree level?
-       //      (leave the first page of leaves alone)
+       //      now delete old fence key
 
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-         if( set->page->lvl )
-               return bt_removeroot (bt, parent, set);
+       if( bt_deletekey (bt, rightkey+1, *rightkey, lvl+1) )
+               return bt->err;
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unlockpage (BtLockDelete, set->latch);
-       bt_unlockpage (BtLockWrite, set->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
-       bt_unpinlatch (set->latch);
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch(set->latch);
        bt_unpinpool (set->pool);
        return 0;
 }
 
-//     remove both child and parent from the btree
-//     from the fence position in the parent
-//     call with both pages locked for writing
+//     root has a single child
+//     collapse a level from the tree
 
-BTERR bt_removeparent (BtDb *bt, BtPageSet *child, BtPageSet *parent, BtPageSet *right, BtPageSet *rparent, uint lvl)
+BTERR bt_collapseroot (BtDb *bt, BtPageSet *root)
 {
-unsigned char pagefence[256];
+BtPageSet child[1];
 uint idx;
 
-       //  pull right sibling over ourselves and unlock
-
-       memcpy (child->page, right->page, bt->mgr->page_size);
-
-       bt_unlockpage (BtLockWrite, child->latch);
-       bt_unpinlatch (child->latch);
-       bt_unpinpool (child->pool);
-
-       //  install ourselves into right link of old right page
-
-       bt_putid (right->page->right, child->page_no);
-       right->page->goright = 1;       // tell bt_loadpage to go right to us
-       right->page->kill = 1;
-
-       bt_unlockpage (BtLockWrite, right->latch);
-
-       //      remove our slot from our parent
-       //      signal to move right
+  // find the child entry and promote as new root contents
 
-       parent->page->goright = 1;      // tell bt_loadpage to go right to rparent
-       parent->page->kill = 1;
-       parent->page->act--;
-
-       //      redirect right page pointer in right parent to us
-
-       for( idx = 0; idx++ < rparent->page->cnt; )
-         if( !slotptr(rparent->page, idx)->dead )
+  do {
+       for( idx = 0; idx++ < root->page->cnt; )
+         if( !slotptr(root->page, idx)->dead )
                break;
 
-       if( bt_getid (slotptr(rparent->page, idx)->id) != right->page_no )
-               return bt->err = BTERR_struct;
-
-       bt_putid (slotptr(rparent->page, idx)->id, child->page_no);
-       bt_unlockpage (BtLockWrite, rparent->latch);
-       bt_unpinlatch (rparent->latch);
-       bt_unpinpool (rparent->pool);
+       child->page_no = bt_getid (slotptr(root->page, idx)->id);
 
-       //      free the right page
+       child->latch = bt_pinlatch (bt, child->page_no);
+       bt_lockpage (BtLockDelete, child->latch);
+       bt_lockpage (BtLockWrite, child->latch);
 
-       bt_lockpage (BtLockDelete, right->latch);
-       bt_lockpage (BtLockWrite, right->latch);
-       bt_freepage (bt, right);
+       if( child->pool = bt_pinpool (bt, child->page_no) )
+               child->page = bt_page (bt, child->pool, child->page_no);
+       else
+               return bt->err;
 
-       //      save parent page fence value
+       memcpy (root->page, child->page, bt->mgr->page_size);
+       bt_freepage (bt, child);
 
-       memcpy (pagefence, parent->page->fence, 256);
-       bt_unlockpage (BtLockWrite, parent->latch);
+  } while( root->page->lvl > 1 && root->page->act == 1 );
 
-       return bt_removepage (bt, parent, lvl, pagefence);
+  bt_unlockpage (BtLockWrite, root->latch);
+  bt_unpinlatch (root->latch);
+  bt_unpinpool (root->pool);
+  return 0;
 }
 
-//     remove page from btree
-//     call with page unlocked
-//     returns with page on free list
+//  find and delete key on page by marking delete flag bit
+//  if page becomes empty, delete it from the btree
 
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence)
+BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl)
 {
-BtPageSet parent[1], sibling[1], rparent[1];
-unsigned char newfence[256];
-uint slot, idx;
+unsigned char lowerfence[256], higherfence[256];
+uint slot, idx, dirty = 0, fence, found;
+BtPageSet set[1], right[1];
 BtKey ptr;
 
-       //      load and lock our parent
-
-  while( 1 ) {
-       if( !(slot = bt_loadpage (bt, parent, pagefence+1, *pagefence, lvl+1, BtLockWrite)) )
+       if( slot = bt_loadpage (bt, set, key, len, lvl, BtLockWrite) )
+               ptr = keyptr(set->page, slot);
+       else
                return bt->err;
 
-       //      do we show up in our parent yet?
-
-       if( set->page_no != bt_getid (slotptr (parent->page, slot)->id) ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-
-       //      can we do a simple merge entirely
-       //      between siblings on the parent page?
+       //      are we deleting a fence slot?
 
-       if( slot < parent->page->cnt ) {
-               // find our right neighbor
-               //      right must exist because the stopper prevents
-               //      the rightmost page from deleting
+       fence = slot == set->page->cnt;
 
-               for( idx = slot; idx++ < parent->page->cnt; )
-                 if( !slotptr(parent->page, idx)->dead )
-                       break;
-
-               sibling->page_no = bt_getid (slotptr (parent->page, idx)->id);
-
-               bt_lockpage (BtLockDelete, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-
-               //      merge right if sibling shows up in
-               //  our parent and is not being killed
-
-               if( sibling->page_no == bt_getid (set->page->right) ) {
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-                 bt_lockpage (BtLockParent, sibling->latch);
-                 bt_lockpage (BtLockDelete, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
-
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_mergeright(bt, set, parent, sibling, slot, idx);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockParent, sibling->latch);
-                 bt_unlockpage (BtLockDelete, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
-
-               bt_unlockpage (BtLockDelete, set->latch);
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-
-       //  find our left neighbor in our parent page
-
-       for( idx = slot; --idx; )
-         if( !slotptr(parent->page, idx)->dead )
-               break;
-
-       //      if no left neighbor, delete ourselves and our parent
-
-       if( !idx ) {
-               bt_lockpage (BtLockAccess, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockAccess, set->latch);
-
-               rparent->page_no = bt_getid (parent->page->right);
-               rparent->latch = bt_pinlatch (bt, rparent->page_no);
-
-               bt_lockpage (BtLockAccess, rparent->latch);
-               bt_lockpage (BtLockWrite, rparent->latch);
-               bt_unlockpage (BtLockAccess, rparent->latch);
-
-               if( rparent->pool = bt_pinpool (bt, rparent->page_no) )
-                       rparent->page = bt_page (bt, rparent->pool, rparent->page_no);
-               else
-                       return bt->err;
-
-               if( !rparent->page->kill ) {
-                 sibling->page_no = bt_getid (set->page->right);
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-
-                 bt_lockpage (BtLockAccess, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockAccess, sibling->latch);
-
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_removeparent (bt, set, parent, sibling, rparent, lvl+1);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
+       // if key is found delete it, otherwise ignore request
 
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, rparent->latch);
-               bt_unpinlatch (rparent->latch);
-               bt_unpinpool (rparent->pool);
+       if( found = !keycmp (ptr, key, len) )
+         if( found = slotptr(set->page, slot)->dead == 0 ) {
+               dirty = slotptr(set->page, slot)->dead = 1;
+               set->page->dirty = 1;
+               set->page->act--;
 
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
+               // collapse empty slots
 
-       // redirect parent to our left sibling
-       // lock and map our left sibling's page
+               while( idx = set->page->cnt - 1 )
+                 if( slotptr(set->page, idx)->dead ) {
+                       *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
+                       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+                 } else
+                       break;
+                 }
 
-       sibling->page_no = bt_getid (slotptr(parent->page, idx)->id);
-       sibling->latch = bt_pinlatch (bt, sibling->page_no);
+       //      did we delete a fence key in an upper level?
 
-       //      wait our turn on fence key maintenance
+       if( dirty && lvl && set->page->act && fence )
+         if( bt_fixfence (bt, set, lvl) )
+               return bt->err;
+         else
+               return bt->found = found, 0;
 
-       bt_lockpage(BtLockParent, sibling->latch);
-       bt_lockpage(BtLockAccess, sibling->latch);
-       bt_lockpage(BtLockWrite, sibling->latch);
-       bt_unlockpage(BtLockAccess, sibling->latch);
+       //      is this a collapsed root?
 
-       if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-       else
+       if( lvl > 1 && set->page_no == ROOT_page && set->page->act == 1 )
+         if( bt_collapseroot (bt, set) )
                return bt->err;
+         else
+               return bt->found = found, 0;
 
-       //  wait until left sibling is in our parent
+       //      return if page is not empty
 
-       if( bt_getid (sibling->page->right) != set->page_no ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unlockpage (BtLockWrite, sibling->latch);
-               bt_unlockpage (BtLockParent, sibling->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-               bt_unpinlatch (sibling->latch);
-               bt_unpinpool (sibling->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
+       if( set->page->act ) {
+               bt_unlockpage(BtLockWrite, set->latch);
+               bt_unpinlatch (set->latch);
+               bt_unpinpool (set->pool);
+               return bt->found = found, 0;
        }
 
-       //      delete our left sibling from parent
+       //      cache copy of fence key
+       //      to post in parent
 
-       slotptr(parent->page,idx)->dead = 1;
-       parent->page->dirty = 1;
-       parent->page->act--;
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (lowerfence, ptr, ptr->len + 1);
 
-       //      redirect our parent slot to our left sibling
+       //      obtain lock on right page
 
-       bt_putid (slotptr(parent->page, slot)->id, sibling->page_no);
-       memcpy (sibling->page->right, set->page->right, BtId);
-
-       //      collapse dead slots from parent
-
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, parent->page->cnt);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
-
-       //  free our original page
-
-       bt_lockpage (BtLockDelete, set->latch);
-       bt_lockpage (BtLockWrite, set->latch);
-       bt_freepage (bt, set);
-
-       //      go down the left node's fence keys to the leaf level
-       //      and update the fence keys in each page
-
-       memcpy (newfence, parent->page->fence, 256);
-
-       if( bt_fixfences (bt, sibling, newfence) )
-               return bt->err;
+       right->page_no = bt_getid(set->page->right);
+       right->latch = bt_pinlatch (bt, right->page_no);
+       bt_lockpage (BtLockWrite, right->latch);
 
-       //  promote sibling as new root?
+       // pin page contents
 
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-        if( sibling->page->lvl ) {
-         sibling->latch = bt_pinlatch (bt, sibling->page_no);
-         bt_lockpage (BtLockDelete, sibling->latch);
-         bt_lockpage (BtLockWrite, sibling->latch);
+       if( right->pool = bt_pinpool (bt, right->page_no) )
+               right->page = bt_page (bt, right->pool, right->page_no);
+       else
+               return 0;
 
-         if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-         else
-               return bt->err;
+       if( right->page->kill )
+               return bt->err = BTERR_struct;
 
-         return bt_removeroot (bt, parent, sibling);
-        }
+       // pull contents of right peer into our empty page
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
+       memcpy (set->page, right->page, bt->mgr->page_size);
 
-       return 0;
-  }
-}
+       // cache copy of key to update
 
-//  find and delete key on page by marking delete flag bit
-//  if page becomes empty, delete it from the btree
+       ptr = keyptr(right->page, right->page->cnt);
+       memcpy (higherfence, ptr, ptr->len + 1);
 
-BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len)
-{
-unsigned char pagefence[256];
-uint slot, idx, found;
-BtPageSet set[1];
-BtKey ptr;
+       // mark right page deleted and point it to left page
+       //      until we can post parent updates
 
-       if( slot = bt_loadpage (bt, set, key, len, 0, BtLockWrite) )
-               ptr = keyptr(set->page, slot);
-       else
-               return bt->err;
+       bt_putid (right->page->right, set->page_no);
+       right->page->kill = 1;
 
-       // if key is found delete it, otherwise ignore request
+       bt_lockpage (BtLockParent, right->latch);
+       bt_unlockpage (BtLockWrite, right->latch);
 
-       if( found = slot <= set->page->cnt )
-         if( found = !keycmp (ptr, key, len) )
-               if( found = slotptr(set->page, slot)->dead == 0 ) {
-                 slotptr(set->page,slot)->dead = 1;
-                 set->page->dirty = 1;
-                 set->page->act--;
+       bt_lockpage (BtLockParent, set->latch);
+       bt_unlockpage (BtLockWrite, set->latch);
 
-                 // collapse empty slots
+       // redirect higher key directly to our new node contents
 
-                 while( idx = set->page->cnt - 1 )
-                       if( slotptr(set->page, idx)->dead ) {
-                         *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
-                         memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
-                       } else
-                               break;
-               }
+       if( bt_insertkey (bt, higherfence+1, *higherfence, lvl+1, set->page_no, time(NULL)) )
+         return bt->err;
 
-       if( set->page->act ) {
-               bt_unlockpage(BtLockWrite, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               return bt->found = found, 0;
-       }
+       //      delete old lower key to our node
 
-       memcpy (pagefence, set->page->fence, 256);
-       set->page->kill = 1;
+       if( bt_deletekey (bt, lowerfence+1, *lowerfence, lvl+1) )
+         return bt->err;
 
-       bt_unlockpage (BtLockWrite, set->latch);
+       //      obtain delete and write locks to right node
 
-       if( bt_removepage (bt, set, 0, pagefence) )
-               return bt->err;
+       bt_unlockpage (BtLockParent, right->latch);
+       bt_lockpage (BtLockDelete, right->latch);
+       bt_lockpage (BtLockWrite, right->latch);
+       bt_freepage (bt, right);
 
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch (set->latch);
+       bt_unpinpool (set->pool);
        bt->found = found;
        return 0;
 }
@@ -2080,7 +1766,7 @@ BtKey ptr;
 
 uint bt_cleanpage(BtDb *bt, BtPage page, uint amt, uint slot)
 {
-uint nxt = bt->mgr->page_size, off;
+uint nxt = bt->mgr->page_size;
 uint cnt = 0, idx = 0;
 uint max = page->cnt;
 uint newslot = max;
@@ -2108,26 +1794,22 @@ BtKey key;
        while( cnt++ < max ) {
                if( cnt == slot )
                        newslot = idx + 1;
-               if( slotptr(bt->frame,cnt)->dead )
+               if( cnt < max && slotptr(bt->frame,cnt)->dead )
                        continue;
 
-               // if its not the fence key,
                // copy the key across
 
-               off = slotptr(bt->frame,cnt)->off;
-
-               if( off >= sizeof(*page) ) {
-                       key = keyptr(bt->frame, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)page + nxt, key, key->len + 1);
-               }
+               key = keyptr(bt->frame, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)page + nxt, key, key->len + 1);
 
                // copy slot
 
                memcpy(slotptr(page, ++idx)->id, slotptr(bt->frame, cnt)->id, BtId);
+               if( !(slotptr(page, idx)->dead = slotptr(bt->frame, cnt)->dead) )
+                       page->act++;
                slotptr(page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(page, idx)->off = off;
-               page->act++;
+               slotptr(page, idx)->off = nxt;
        }
 
        page->min = nxt;
@@ -2143,42 +1825,38 @@ BtKey key;
 
 // split the root and raise the height of the btree
 
-BTERR bt_splitroot(BtDb *bt, BtPageSet *root, uid page_no2)
+BTERR bt_splitroot(BtDb *bt, BtPageSet *root, unsigned char *leftkey, uid page_no2)
 {
 uint nxt = bt->mgr->page_size;
-unsigned char leftkey[256];
-uid new_page;
+uid left;
 
        //  Obtain an empty page to use, and copy the current
        //  root contents into it, e.g. lower keys
 
-       memcpy (leftkey, root->page->fence, 256);
-       root->page->posted = 1;
-
-       if( !(new_page = bt_newpage(bt, root->page)) )
+       if( !(left = bt_newpage(bt, root->page)) )
                return bt->err;
 
        // preserve the page info at the bottom
        // of higher keys and set rest to zero
 
        memset(root->page+1, 0, bt->mgr->page_size - sizeof(*root->page));
-       memset(root->page->fence, 0, 256);
-       root->page->fence[0] = 2;
-       root->page->fence[1] = 0xff;
-       root->page->fence[2] = 0xff;
 
-       // insert lower keys page fence key on newroot page
+       // insert lower keys page fence key on newroot page as first key
 
        nxt -= *leftkey + 1;
        memcpy ((unsigned char *)root->page + nxt, leftkey, *leftkey + 1);
-       bt_putid(slotptr(root->page, 1)->id, new_page);
+       bt_putid(slotptr(root->page, 1)->id, left);
        slotptr(root->page, 1)->off = nxt;
        
        // insert stopper key on newroot page
        // and increase the root height
 
+       nxt -= 3;
+       ((unsigned char *)root->page)[nxt] = 2;
+       ((unsigned char *)root->page)[nxt+1] = 0xff;
+       ((unsigned char *)root->page)[nxt+2] = 0xff;
        bt_putid(slotptr(root->page, 2)->id, page_no2);
-       slotptr(root->page, 2)->off = offsetof(struct BtPage_, fence);
+       slotptr(root->page, 2)->off = nxt;
 
        bt_putid(root->page->right, 0);
        root->page->min = nxt;          // reset lowest used offset and key count
@@ -2199,9 +1877,10 @@ uid new_page;
 
 BTERR bt_splitpage (BtDb *bt, BtPageSet *set)
 {
-uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size, off;
+uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size;
 unsigned char fencekey[256];
 uint lvl = set->page->lvl;
+uint prev;
 uid right;
 BtKey key;
 
@@ -2213,23 +1892,17 @@ BtKey key;
        idx = 0;
 
        while( cnt++ < max ) {
-               if( !lvl || cnt < max ) {
-                       key = keyptr(set->page, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
-               } else
-                       off = offsetof(struct BtPage_, fence);
+               key = keyptr(set->page, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
 
                memcpy(slotptr(bt->frame,++idx)->id, slotptr(set->page,cnt)->id, BtId);
+               if( !(slotptr(bt->frame, idx)->dead = slotptr(set->page, cnt)->dead) )
+                       bt->frame->act++;
                slotptr(bt->frame, idx)->tod = slotptr(set->page, cnt)->tod;
-               slotptr(bt->frame, idx)->off = off;
-               bt->frame->act++;
+               slotptr(bt->frame, idx)->off = nxt;
        }
 
-       if( set->page_no == ROOT_page )
-               bt->frame->posted = 1;
-
-       memcpy (bt->frame->fence, set->page->fence, 256);
        bt->frame->bits = bt->mgr->page_bits;
        bt->frame->min = nxt;
        bt->frame->cnt = idx;
@@ -2260,24 +1933,17 @@ BtKey key;
 
        while( cnt++ < max / 2 ) {
                key = keyptr(bt->frame, cnt);
-
-               if( !lvl || cnt < max / 2 ) {
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
-               } else 
-                       off = offsetof(struct BtPage_, fence);
-
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
                memcpy(slotptr(set->page,++idx)->id, slotptr(bt->frame,cnt)->id, BtId);
                slotptr(set->page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(set->page, idx)->off = off;
+               slotptr(set->page, idx)->off = nxt;
                set->page->act++;
        }
 
-       // install fence key for smaller key page
-
-       memset(set->page->fence, 0, 256);
-       memcpy(set->page->fence, key, key->len + 1);
+       // remember fence key for smaller page
 
+       memcpy(fencekey, key, key->len + 1);
        bt_putid(set->page->right, right);
        set->page->min = nxt;
        set->page->cnt = idx;
@@ -2285,20 +1951,20 @@ BtKey key;
        // if current page is the root page, split it
 
        if( set->page_no == ROOT_page )
-               return bt_splitroot (bt, set, right);
+               return bt_splitroot (bt, set, fencekey, right);
 
-       bt_unlockpage (BtLockWrite, set->latch);
+       right = 0;
 
        // insert new fences in their parent pages
 
        while( 1 ) {
                bt_lockpage (BtLockParent, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
 
-               memcpy (fencekey, set->page->fence, 256);
-               right = bt_getid (set->page->right);
+               key = keyptr (set->page, set->page->cnt);
+               memcpy (fencekey, key, key->len + 1);
+               prev = set->page->posted;
 
-               if( set->page->posted ) {
+               if( right && prev ) {
                        bt_unlockpage (BtLockParent, set->latch);
                        bt_unlockpage (BtLockWrite, set->latch);
                        bt_unpinlatch (set->latch);
@@ -2306,10 +1972,15 @@ BtKey key;
                        return 0;
                }
 
+               right = bt_getid (set->page->right);
                set->page->posted = 1;
+
                bt_unlockpage (BtLockWrite, set->latch);
 
-               if( bt_insertkey (bt, fencekey+1, *fencekey, set->page_no, time(NULL), lvl+1) )
+               // insert new fence for reformulated left block of smaller keys
+
+               if( !prev )
+                 if( bt_insertkey (bt, fencekey+1, *fencekey, lvl+1, set->page_no, time(NULL)) )
                        return bt->err;
 
                bt_unlockpage (BtLockParent, set->latch);
@@ -2325,6 +1996,8 @@ BtKey key;
                        set->page = bt_page (bt, set->pool, right);
                else
                        return bt->err;
+
+               bt_lockpage (BtLockWrite, set->latch);
        }
 
        return 0;
@@ -2332,7 +2005,7 @@ BtKey key;
 
 //  Insert new key into the btree at given level.
 
-BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl)
+BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod)
 {
 BtPageSet set[1];
 uint slot, idx;
@@ -2350,8 +2023,7 @@ BtKey ptr;
 
                // if key already exists, update id and return
 
-               if( slot <= set->page->cnt )
-                 if( !keycmp (ptr, key, len) ) {
+               if( !keycmp (ptr, key, len) ) {
                        if( slotptr(set->page, slot)->dead )
                                set->page->act++;
                        slotptr(set->page, slot)->dead = 0;
@@ -2378,14 +2050,14 @@ BtKey ptr;
        ((unsigned char *)set->page)[set->page->min] = len;
        memcpy ((unsigned char *)set->page + set->page->min +1, key, len );
 
-       for( idx = slot; idx <= set->page->cnt; idx++ )
+       for( idx = slot; idx < set->page->cnt; idx++ )
          if( slotptr(set->page, idx)->dead )
                break;
 
        // now insert key into array before slot
 
-       if( idx > set->page->cnt )
-               set->page->cnt++;
+       if( idx == set->page->cnt )
+               idx++, set->page->cnt++;
 
        set->page->act++;
 
@@ -2435,6 +2107,7 @@ uid right;
 
   do {
        right = bt_getid(bt->cursor->right);
+
        while( slot++ < bt->cursor->cnt )
          if( slotptr(bt->cursor,slot)->dead )
                continue;
@@ -2462,6 +2135,7 @@ uid right;
        bt_unpinlatch (set->latch);
        bt_unpinpool (set->pool);
        slot = 0;
+
   } while( 1 );
 
   return bt->err = 0;
@@ -2488,10 +2162,11 @@ uint bt_tod(BtDb *bt, uint slot)
 void bt_latchaudit (BtDb *bt)
 {
 ushort idx, hashidx;
+uid next, page_no;
 BtLatchSet *latch;
 BtPool *pool;
 BtPage page;
-uid page_no;
+BtKey ptr;
 
 #ifdef unix
        for( idx = 1; idx < bt->mgr->latchmgr->latchdeployed; idx++ ) {
@@ -2528,18 +2203,21 @@ uid page_no;
          } while( idx = latch->next );
        }
 
-       page_no = bt_getid(bt->mgr->latchmgr->alloc[1].right);
-
-       while( page_no ) {
-               fprintf(stderr, "free: %.6x\n", (uint)page_no);
-
-               if( pool = bt_pinpool (bt, page_no) )
-                       page = bt_page (bt, pool, page_no);
-               else
-                       return;
-
-           page_no = bt_getid(page->right);
-               bt_unpinpool (pool);
+       next = bt->mgr->latchmgr->nlatchpage + LATCH_page;
+       page_no = LEAF_page;
+
+       while( page_no < bt_getid(bt->mgr->latchmgr->alloc->right) ) {
+               pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, page_no << bt->mgr->page_bits);
+               if( !bt->frame->free )
+                for( idx = 0; idx++ < bt->frame->cnt - 1; ) {
+                 ptr = keyptr(bt->frame, idx+1);
+                 if( keycmp (keyptr(bt->frame, idx), ptr->key, ptr->len) >= 0 )
+                       fprintf(stderr, "page %.8x idx %.2x out of order\n", page_no, idx);
+                }
+
+               if( page_no > LEAF_page )
+                       next = page_no + 1;
+               page_no = next;
        }
 #endif
 }
@@ -2596,7 +2274,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_insertkey (bt, key, len, line, *tod, 0) )
+                         if( bt_insertkey (bt, key, len, 0, line, *tod) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2618,7 +2296,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_deletekey (bt, key, len) )
+                         if( bt_deletekey (bt, key, len, 0) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2644,6 +2322,8 @@ FILE *in;
                                found++;
                          else if( bt->err )
                                fprintf(stderr, "Error %d Syserr %d Line: %d\n", bt->err, errno, line), exit(0);
+                         else
+                               fprintf(stderr, "Unable to find key %.*s line %d\n", len, key, line);
                          len = 0;
                        }
                        else if( len < 255 )
@@ -2686,7 +2366,20 @@ FILE *in;
                page_no = LEAF_page;
 
                while( page_no < bt_getid(bt->mgr->latchmgr->alloc->right) ) {
-                       pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, page_no << bt->mgr->page_bits);
+               uid off = page_no << bt->mgr->page_bits;
+#ifdef unix
+                 pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, off);
+#else
+               DWORD amt[1];
+
+                 SetFilePointer (bt->mgr->idx, (long)off, (long*)(&off)+1, FILE_BEGIN);
+
+                 if( !ReadFile(bt->mgr->idx, bt->frame, bt->mgr->page_size, amt, NULL))
+                       return bt->err = BTERR_map;
+
+                 if( *amt <  bt->mgr->page_size )
+                       return bt->err = BTERR_map;
+#endif
                        if( !bt->frame->free && !bt->frame->lvl )
                                cnt += bt->frame->act;
                        if( page_no > LEAF_page )
index e2faef4f45d64020b1ec629fe66cdaa15913be28..ce186a60b2e52fb3c1150bfd03b081b5f02a6575 100644 (file)
@@ -1,6 +1,6 @@
 // btree version threads2j linux futex concurrency version
 //     with reworked bt_deletekey
-// 12 FEB 2014
+// 17 FEB 2014
 
 // author: karl malbrain, malbrain@cal.berkeley.edu
 
@@ -87,19 +87,12 @@ typedef enum{
        BtLockDelete,
        BtLockRead,
        BtLockWrite,
-       BtLockParent
+       BtLockParent,
+       BtLockParentWrt
 } BtLock;
 
 //     mode & definition for latch implementation
 
-enum {
-       Mutex = 1 << 0,         // the mutex bit
-       Write = 1 << 1,         // the writers bit
-       Share = 1 << 2,         // reader count
-       PendRd = 1 << 12,       // reader contended count
-       PendWr = 1 << 22        // writer contended count
-} LockMode;
-
 enum {
        QueRd = 1,      // reader queue
        QueWr = 2       // writer queue
@@ -109,11 +102,14 @@ enum {
 // grant write lock when share == 0
 
 typedef struct {
-       volatile uint mutex:1;          // 1 = busy
-       volatile uint write:1;          // 1 = exclusive
-       volatile uint share:10;         // count of readers holding locks
-       volatile uint readwait:10;      // count of readers waiting
-       volatile uint writewait:10;     // count of writers waiting
+       volatile unsigned char mutex;           // 1 = busy
+       volatile unsigned char write:1;         // 1 = exclusive
+       volatile unsigned char readwait:1;      // readers are waiting
+       volatile unsigned char writewait:1;     // writers are waiting
+       volatile unsigned char filler:5;
+       volatile ushort share;                          // count of readers holding locks
+       volatile ushort rcnt;                           // count of waiting readers
+       volatile ushort wcnt;                           // count of waiting writers
 } BtLatch;
 
 //     Define the length of the page and key pointers
@@ -139,7 +135,7 @@ typedef struct {
 } BtSlot;
 
 //     The key structure occupies space at the upper end of
-//     each page.  It's a length byte followed by the value
+//     each page.  It's a length byte followed by the key
 //     bytes.
 
 typedef struct {
@@ -157,13 +153,11 @@ typedef struct BtPage_ {
        uint min;                                       // next key offset
        unsigned char bits:7;           // page size in bits
        unsigned char free:1;           // page is on free list
-       unsigned char lvl:4;            // level of page
+       unsigned char lvl:5;            // level of page
        unsigned char kill:1;           // page is being deleted
        unsigned char dirty:1;          // page has deleted keys
        unsigned char posted:1;         // page fence has posted
-       unsigned char goright:1;        // page is being killed, continue to right
        unsigned char right[BtId];      // page number to right
-       unsigned char fence[256];       // page fence key
 } *BtPage;
 
 //  hash table entries
@@ -275,21 +269,17 @@ typedef enum {
 // B-Tree functions
 extern void bt_close (BtDb *bt);
 extern BtDb *bt_open (BtMgr *mgr);
-extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl);
-extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len);
+extern BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod);
+extern BTERR  bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl);
 extern uid bt_findkey    (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_startkey  (BtDb *bt, unsigned char *key, uint len);
 extern uint bt_nextkey   (BtDb *bt, uint slot);
 
-//     internal functions
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence);
-
 //     manager functions
 extern BtMgr *bt_mgr (char *name, uint mode, uint bits, uint poolsize, uint segsize, uint hashsize);
 void bt_mgrclose (BtMgr *mgr);
 
 //  Helper functions to return slot values
-
 extern BtKey bt_key (BtDb *bt, uint slot);
 extern uid bt_uid (BtDb *bt, uint slot);
 extern uint bt_tod (BtDb *bt, uint slot);
@@ -313,7 +303,8 @@ extern uint bt_tod (BtDb *bt, uint slot);
 //  A key consists of a length byte, two bytes of
 //  index number (0 - 65534), and up to 253 bytes
 //  of key value.  Duplicate keys are discarded.
-//  Associated with each key is a 48 bit row-id.
+//  Associated with each key is a 48 bit row-id,
+//     or any other value desired.
 
 //  The b-tree root is always located at page 1.
 //     The first leaf page of level zero is always
@@ -329,7 +320,7 @@ extern uint bt_tod (BtDb *bt, uint slot);
 
 //     Deleted keys are marked with a dead bit until
 //     page cleanup. The fence key for a node is
-//     present in a special array.
+//     always present.
 
 //  Groups of pages called segments from the btree are optionally
 //  cached with a memory mapped pool. A hash table is used to keep
@@ -386,6 +377,7 @@ int sys_futex(void *addr1, int op, int val1, struct timespec *timeout, void *add
 
 void bt_spinreadlock(BtLatch *latch, int private)
 {
+ushort decr = 0;
 uint prev;
 
   if( private )
@@ -393,27 +385,31 @@ uint prev;
 
   while( 1 ) {
        //      obtain latch mutex
-       if( __sync_fetch_and_or((uint *)latch, Mutex) & Mutex ) {
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
                sched_yield();
-               continue;
-       }
+
+       if( decr )
+               latch->rcnt--, decr = 0;
 
        //  wait for writers to clear
        //      increment read waiters and wait
 
        if( latch->write || latch->writewait ) {
-               __sync_fetch_and_add ((uint *)latch, PendRd);
-               prev = __sync_fetch_and_and ((uint *)latch, ~Mutex) & ~Mutex;
+               latch->readwait = 1;
+               latch->rcnt++;
+               prev = *(uint *)latch & ~1;
+               __sync_lock_release (&latch->mutex);
                sys_futex( (uint *)latch, FUTEX_WAIT_BITSET | private, prev, NULL, NULL, QueRd );
-               __sync_fetch_and_sub ((uint *)latch, PendRd);
+               decr = 1;
                continue;
        }
        
        // increment reader lock count
        // and release latch mutex
 
-       __sync_fetch_and_add ((uint *)latch, Share);
-       __sync_fetch_and_and ((uint *)latch, ~Mutex);
+       latch->readwait = 0;
+       latch->share++;
+       __sync_lock_release (&latch->mutex);
        return;
   }
 }
@@ -422,6 +418,7 @@ uint prev;
 
 void bt_spinwritelock(BtLatch *latch, int private)
 {
+ushort decr = 0;
 uint prev;
 
   if( private )
@@ -429,26 +426,32 @@ uint prev;
 
   while( 1 ) {
        //      obtain latch mutex
-       if( __sync_fetch_and_or((uint *)latch, Mutex) & Mutex ) {
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
                sched_yield();
-               continue;
-       }
+
+       if( decr )
+               latch->wcnt--, decr = 0;
 
        //      wait for write and reader count to clear
 
        if( latch->write || latch->share ) {
-               __sync_fetch_and_add ((uint *)latch, PendWr);
-               prev = __sync_fetch_and_and ((uint *)latch, ~Mutex) & ~Mutex;
+               latch->writewait = 1;
+               latch->wcnt++;
+               prev = *(uint *)latch & ~1;
+               __sync_lock_release (&latch->mutex);
                sys_futex( (uint *)latch, FUTEX_WAIT_BITSET | private, prev, NULL, NULL, QueWr );
-               __sync_fetch_and_sub ((uint *)latch, PendWr);
+               decr = 1;
                continue;
        }
        
        //      take write mutex
        //      release latch mutex
 
-       __sync_fetch_and_or ((uint *)latch, Write);
-       __sync_fetch_and_and ((uint *)latch, ~Mutex);
+       if( !latch->wcnt )
+               latch->writewait = 0;
+
+       latch->write = 1;
+       __sync_lock_release (&latch->mutex);
        return;
   }
 }
@@ -465,20 +468,19 @@ int ans;
        //      try for mutex,
        //      abandon request if not taken
 
-       if( __sync_fetch_and_or((uint *)latch, Mutex) & Mutex )
+       if( __sync_lock_test_and_set(&latch->mutex, 1) )
                return 0;
 
        //      see if write mode is available
 
-       if( !latch->write && !latch->share ) {
-               __sync_fetch_and_or ((uint *)latch, Write);
-               ans = 1;
-       } else
+       if( !latch->write && !latch->share )
+               ans = latch->write = 1;
+       else
                ans = 0;
 
        // release latch mutex
 
-       __sync_fetch_and_and ((uint *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
        return ans;
 }
 
@@ -491,24 +493,24 @@ void bt_spinreleasewrite(BtLatch *latch, int private)
 
        //      obtain latch mutex
 
-       while( __sync_fetch_and_or((uint *)latch, Mutex) & Mutex )
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
                sched_yield();
 
-       __sync_fetch_and_and ((uint *)latch, ~Write);
+       latch->write = 0;
 
        // favor writers
 
-       if( latch->writewait )
+       if( latch->wcnt )
          if( sys_futex( (uint *)latch, FUTEX_WAKE_BITSET | private, 1, NULL, NULL, QueWr ) )
                goto wakexit;
 
-       if( latch->readwait )
+       if( latch->rcnt )
                sys_futex( (uint *)latch, FUTEX_WAKE_BITSET | private, INT_MAX, NULL, NULL, QueRd );
 
        // release latch mutex
 
 wakexit:
-       __sync_fetch_and_and ((uint *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 }
 
 //     decrement reader count
@@ -520,19 +522,19 @@ void bt_spinreleaseread(BtLatch *latch, int private)
 
        //      obtain latch mutex
 
-       while( __sync_fetch_and_or((uint *)latch, Mutex) & Mutex )
+       while( __sync_lock_test_and_set(&latch->mutex, 1) )
                sched_yield();
 
-       __sync_fetch_and_sub ((uint *)latch, Share);
+       latch->share--;
 
        // wake waiting writers
 
-       if( !latch->share && latch->writewait )
+       if( !latch->share && latch->wcnt )
                sys_futex( (uint *)latch, FUTEX_WAKE_BITSET | private, 1, NULL, NULL, QueWr );
 
        // release latch mutex
 
-       __sync_fetch_and_and ((uint *)latch, ~Mutex);
+       __sync_lock_release (&latch->mutex);
 }
 
 //     link latch table entry into latch hash table
@@ -917,12 +919,13 @@ SYSTEM_INFO sysinfo[1];
        latchmgr->alloc->bits = mgr->page_bits;
 
        for( lvl=MIN_lvl; lvl--; ) {
-               slotptr(latchmgr->alloc, 1)->off = offsetof(struct BtPage_, fence);
+               slotptr(latchmgr->alloc, 1)->off = mgr->page_size - 3;
                bt_putid(slotptr(latchmgr->alloc, 1)->id, lvl ? MIN_lvl - lvl + 1 : 0);         // next(lower) page number
-               latchmgr->alloc->fence[0] = 2;                  // create stopper key
-               latchmgr->alloc->fence[1] = 0xff;
-               latchmgr->alloc->fence[2] = 0xff;
-               latchmgr->alloc->min = mgr->page_size;
+               key = keyptr(latchmgr->alloc, 1);
+               key->len = 2;           // create stopper key
+               key->key[0] = 0xff;
+               key->key[1] = 0xff;
+               latchmgr->alloc->min = mgr->page_size - 3;
                latchmgr->alloc->lvl = lvl;
                latchmgr->alloc->cnt = 1;
                latchmgr->alloc->act = 1;
@@ -1115,7 +1118,7 @@ int flag;
 
 #ifdef unix
        flag = PROT_READ | ( bt->mgr->mode == BT_ro ? 0 : PROT_WRITE );
-       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED | MAP_POPULATE, bt->mgr->idx, off);
+       pool->map = mmap (0, (bt->mgr->poolmask+1) << bt->mgr->page_bits, flag, MAP_SHARED, bt->mgr->idx, off);
        if( pool->map == MAP_FAILED )
                return bt->err = BTERR_map;
 
@@ -1318,6 +1321,10 @@ void bt_lockpage(BtLock mode, BtLatchSet *set)
        case BtLockParent:
                bt_spinwritelock (set->parent, 0);
                break;
+       case BtLockParentWrt:
+               bt_spinwritelock (set->parent, 0);
+               bt_spinwritelock (set->readwr, 0);
+               break;
        }
 }
 
@@ -1341,6 +1348,10 @@ void bt_unlockpage(BtLock mode, BtLatchSet *set)
        case BtLockParent:
                bt_spinreleasewrite (set->parent, 0);
                break;
+       case BtLockParentWrt:
+               bt_spinreleasewrite (set->parent, 0);
+               bt_spinreleasewrite (set->readwr, 0);
+               break;
        }
 }
 
@@ -1408,44 +1419,38 @@ int reuse;
 int bt_findslot (BtPageSet *set, unsigned char *key, uint len)
 {
 uint diff, higher = set->page->cnt, low = 1, slot;
+uint good = 0;
 
        //        make stopper key an infinite fence value
 
        if( bt_getid (set->page->right) )
                higher++;
+       else
+               good++;
 
        //      low is the lowest candidate.
        //  loop ends when they meet
 
        //  higher is already
-       //      tested as .ge. the given key.
+       //      tested as .ge. the passed key.
 
        while( diff = higher - low ) {
                slot = low + ( diff >> 1 );
                if( keycmp (keyptr(set->page, slot), key, len) < 0 )
                        low = slot + 1;
                else
-                       higher = slot;
+                       higher = slot, good++;
        }
 
-       if( higher <= set->page->cnt )
-               return higher;
-
-       //      if leaf page, compare against fence value
-
        //      return zero if key is on right link page
-       //      or return slot beyond last key
 
-       if( set->page->lvl || keycmp ((BtKey)set->page->fence, key, len) < 0 )
-               return 0;
-
-       return higher;
+       return good ? higher : 0;
 }
 
 //  find and load page at given level for given key
 //     leave page rd or wr locked as requested
 
-int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, uint lock)
+int bt_loadpage (BtDb *bt, BtPageSet *set, unsigned char *key, uint len, uint lvl, BtLock lock)
 {
 uid page_no = ROOT_page, prevpage = 0;
 uint drill = 0xff, slot;
@@ -1457,7 +1462,7 @@ BtPool *prevpool;
 
   do {
        // determine lock mode of drill level
-       mode = (lock == BtLockWrite) && (drill == lvl) ? BtLockWrite : BtLockRead; 
+       mode = (drill == lvl) ? lock : BtLockRead; 
 
        set->latch = bt_pinlatch (bt, page_no);
        set->page_no = page_no;
@@ -1487,6 +1492,9 @@ BtPool *prevpool;
 
        bt_lockpage(mode, set->latch);
 
+       if( set->page->free )
+               return bt->err = BTERR_struct, 0;
+
        if( page_no > ROOT_page )
          bt_unlockpage(BtLockAccess, set->latch);
 
@@ -1498,7 +1506,7 @@ BtPool *prevpool;
                        
                drill = set->page->lvl;
 
-               if( lock == BtLockWrite && drill == lvl ) {
+               if( lock != BtLockRead && drill == lvl ) {
                  bt_unlockpage(mode, set->latch);
                  bt_unpinlatch (set->latch);
                  bt_unpinpool (set->pool);
@@ -1511,53 +1519,28 @@ BtPool *prevpool;
        prevpool = set->pool;
        prevmode = mode;
 
-       //      if page is being deleted and we should continue right
-
-       if( set->page->kill && set->page->goright ) {
-               page_no = bt_getid (set->page->right);
-               continue;
-       }
-
-       //      otherwise, wait for deleted node to clear
-
-       if( set->page->kill ) {
-               bt_unlockpage(mode, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               page_no = ROOT_page;
-               prevpage = 0;
-               drill = 0xff;
-#ifdef unix
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-       
        //  find key on page at this level
        //  and descend to requested level
 
-       if( slot = bt_findslot (set, key, len) ) {
+       if( !set->page->kill )
+        if( slot = bt_findslot (set, key, len) ) {
          if( drill == lvl )
                return slot;
 
-         if( slot > set->page->cnt )
-               return bt->err = BTERR_struct;
-
          while( slotptr(set->page, slot)->dead )
                if( slot++ < set->page->cnt )
                        continue;
                else
-                       return bt->err = BTERR_struct, 0;
+                       goto slideright;
 
          page_no = bt_getid(slotptr(set->page, slot)->id);
          drill--;
          continue;
-       }
+        }
 
        //  or slide right into next page
 
+slideright:
        page_no = bt_getid(set->page->right);
 
   } while( page_no );
@@ -1568,61 +1551,6 @@ BtPool *prevpool;
   return 0;    // return error
 }
 
-// drill down fixing fence values for left sibling tree
-
-//  call with set write locked
-//     return with set unlocked & unpinned.
-
-BTERR bt_fixfences (BtDb *bt, BtPageSet *set, unsigned char *newfence)
-{
-unsigned char oldfence[256];
-BtPageSet next[1];
-int chk;
-
-  memcpy (oldfence, set->page->fence, 256);
-  next->page_no = bt_getid(slotptr(set->page, set->page->cnt)->id);
-
-  while( !set->page->kill && set->page->lvl ) {
-       next->latch = bt_pinlatch (bt, next->page_no);
-       bt_lockpage (BtLockParent, next->latch);
-       bt_lockpage (BtLockAccess, next->latch);
-       bt_lockpage (BtLockWrite, next->latch);
-       bt_unlockpage (BtLockAccess, next->latch);
-
-       if( next->pool = bt_pinpool (bt, next->page_no) )
-               next->page = bt_page (bt, next->pool, next->page_no);
-       else
-               return bt->err;
-
-       chk = keycmp ((BtKey)next->page->fence, oldfence + 1, *oldfence);
-
-       if( chk < 0 ) {
-         next->page_no = bt_getid (next->page->right);
-         bt_unlockpage (BtLockWrite, next->latch);
-         bt_unlockpage (BtLockParent, next->latch);
-         bt_unpinlatch (next->latch);
-         bt_unpinpool (next->pool);
-         continue;
-       }
-
-       if( chk > 0 )
-               return bt->err = BTERR_struct;
-
-       if( bt_fixfences (bt, next, newfence) )
-               return bt->err;
-
-       break;
-  }
-
-  memcpy (set->page->fence, newfence, 256);
-
-  bt_unlockpage (BtLockWrite, set->latch);
-  bt_unlockpage (BtLockParent, set->latch);
-  bt_unpinlatch (set->latch);
-  bt_unpinpool (set->pool);
-  return 0;
-}
-
 //     return page to free list
 //     page must be delete & write locked
 
@@ -1649,434 +1577,205 @@ void bt_freepage (BtDb *bt, BtPageSet *set)
        bt_spinreleasewrite (bt->mgr->latchmgr->lock, 0);
 }
 
-//     remove the root level by promoting its only child
-//     call with parent and child pages
+//     a fence key was deleted from a page
+//     push new fence value upwards
 
-BTERR bt_removeroot (BtDb *bt, BtPageSet *root, BtPageSet *child)
+BTERR bt_fixfence (BtDb *bt, BtPageSet *set, uint lvl)
 {
-uid next = 0;
-
-  do {
-       if( next ) {
-         child->latch = bt_pinlatch (bt, next);
-         bt_lockpage (BtLockDelete, child->latch);
-         bt_lockpage (BtLockWrite, child->latch);
-
-         if( child->pool = bt_pinpool (bt, next) )
-               child->page = bt_page (bt, child->pool, next);
-         else
-               return bt->err;
+unsigned char leftkey[256], rightkey[256];
+uid page_no;
+BtKey ptr;
+uint idx;
 
-         child->page_no = next;
-       }
+       //      remove the old fence value
 
-       memcpy (root->page, child->page, bt->mgr->page_size);
-       next = bt_getid (slotptr(child->page, child->page->cnt)->id);
-       bt_freepage (bt, child);
-  } while( root->page->lvl > 1 && root->page->cnt == 1 );
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (rightkey, ptr, ptr->len + 1);
 
-  bt_unlockpage (BtLockWrite, root->latch);
-  bt_unpinlatch (root->latch);
-  bt_unpinpool (root->pool);
-  return 0;
-}
+       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+       set->page->dirty = 1;
 
-//  pull right page over ourselves in simple merge
-
-BTERR bt_mergeright (BtDb *bt, BtPageSet *set, BtPageSet *parent, BtPageSet *right, uint slot, uint idx)
-{
-       //  install ourselves as child page
-       //      and delete ourselves from parent
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (leftkey, ptr, ptr->len + 1);
+       page_no = set->page_no;
 
-       bt_putid (slotptr(parent->page, idx)->id, set->page_no);
-       slotptr(parent->page, slot)->dead = 1;
-       parent->page->act--;
+       bt_unlockpage (BtLockWrite, set->latch);
 
-       //      collapse any empty slots
+       //      insert new (now smaller) fence key
 
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, idx + 1);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
+       if( bt_insertkey (bt, leftkey+1, *leftkey, lvl+1, page_no, time(NULL)) )
+         return bt->err;
 
-       memcpy (set->page, right->page, bt->mgr->page_size);
-       bt_unlockpage (BtLockParent, right->latch);
+       //      now delete old fence key
 
-       bt_freepage (bt, right);
-
-       //      do we need to remove a btree level?
-       //      (leave the first page of leaves alone)
-
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-         if( set->page->lvl )
-               return bt_removeroot (bt, parent, set);
+       if( bt_deletekey (bt, rightkey+1, *rightkey, lvl+1) )
+               return bt->err;
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unlockpage (BtLockDelete, set->latch);
-       bt_unlockpage (BtLockWrite, set->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
-       bt_unpinlatch (set->latch);
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch(set->latch);
        bt_unpinpool (set->pool);
        return 0;
 }
 
-//     remove both child and parent from the btree
-//     from the fence position in the parent
-//     call with both pages locked for writing
+//     root has a single child
+//     collapse a level from the tree
 
-BTERR bt_removeparent (BtDb *bt, BtPageSet *child, BtPageSet *parent, BtPageSet *right, BtPageSet *rparent, uint lvl)
+BTERR bt_collapseroot (BtDb *bt, BtPageSet *root)
 {
-unsigned char pagefence[256];
+BtPageSet child[1];
 uint idx;
 
-       //  pull right sibling over ourselves and unlock
-
-       memcpy (child->page, right->page, bt->mgr->page_size);
-
-       bt_unlockpage (BtLockWrite, child->latch);
-       bt_unpinlatch (child->latch);
-       bt_unpinpool (child->pool);
-
-       //  install ourselves into right link of old right page
-
-       bt_putid (right->page->right, child->page_no);
-       right->page->goright = 1;       // tell bt_loadpage to go right to us
-       right->page->kill = 1;
-
-       bt_unlockpage (BtLockWrite, right->latch);
-
-       //      remove our slot from our parent
-       //      signal to move right
-
-       parent->page->goright = 1;      // tell bt_loadpage to go right to rparent
-       parent->page->kill = 1;
-       parent->page->act--;
-
-       //      redirect right page pointer in right parent to us
+  // find the child entry and promote as new root contents
 
-       for( idx = 0; idx++ < rparent->page->cnt; )
-         if( !slotptr(rparent->page, idx)->dead )
+  do {
+       for( idx = 0; idx++ < root->page->cnt; )
+         if( !slotptr(root->page, idx)->dead )
                break;
 
-       if( bt_getid (slotptr(rparent->page, idx)->id) != right->page_no )
-               return bt->err = BTERR_struct;
-
-       bt_putid (slotptr(rparent->page, idx)->id, child->page_no);
-       bt_unlockpage (BtLockWrite, rparent->latch);
-       bt_unpinlatch (rparent->latch);
-       bt_unpinpool (rparent->pool);
+       child->page_no = bt_getid (slotptr(root->page, idx)->id);
 
-       //      free the right page
+       child->latch = bt_pinlatch (bt, child->page_no);
+       bt_lockpage (BtLockDelete, child->latch);
+       bt_lockpage (BtLockWrite, child->latch);
 
-       bt_lockpage (BtLockDelete, right->latch);
-       bt_lockpage (BtLockWrite, right->latch);
-       bt_freepage (bt, right);
+       if( child->pool = bt_pinpool (bt, child->page_no) )
+               child->page = bt_page (bt, child->pool, child->page_no);
+       else
+               return bt->err;
 
-       //      save parent page fence value
+       memcpy (root->page, child->page, bt->mgr->page_size);
+       bt_freepage (bt, child);
 
-       memcpy (pagefence, parent->page->fence, 256);
-       bt_unlockpage (BtLockWrite, parent->latch);
+  } while( root->page->lvl > 1 && root->page->act == 1 );
 
-       return bt_removepage (bt, parent, lvl, pagefence);
+  bt_unlockpage (BtLockParentWrt, root->latch);
+  bt_unpinlatch (root->latch);
+  bt_unpinpool (root->pool);
+  return 0;
 }
 
-//     remove page from btree
-//     call with page unlocked
-//     returns with page on free list
+//  find and delete key on page by marking delete flag bit
+//  if page becomes empty, delete it from the btree
 
-BTERR bt_removepage (BtDb *bt, BtPageSet *set, uint lvl, unsigned char *pagefence)
+BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len, uint lvl)
 {
-BtPageSet parent[1], sibling[1], rparent[1];
-unsigned char newfence[256];
-uint slot, idx;
+unsigned char lowerfence[256], higherfence[256];
+uint slot, idx, dirty = 0, fence, found;
+BtPageSet set[1], right[1];
 BtKey ptr;
 
-       //      load and lock our parent
-
-  while( 1 ) {
-       if( !(slot = bt_loadpage (bt, parent, pagefence+1, *pagefence, lvl+1, BtLockWrite)) )
+       if( slot = bt_loadpage (bt, set, key, len, lvl, BtLockParentWrt) )
+               ptr = keyptr(set->page, slot);
+       else
                return bt->err;
 
-       //      do we show up in our parent yet?
-
-       if( set->page_no != bt_getid (slotptr (parent->page, slot)->id) ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-
-       //      can we do a simple merge entirely
-       //      between siblings on the parent page?
+       //      are we deleting a fence slot?
 
-       if( slot < parent->page->cnt ) {
-               // find our right neighbor
-               //      right must exist because the stopper prevents
-               //      the rightmost page from deleting
+       fence = slot == set->page->cnt;
 
-               for( idx = slot; idx++ < parent->page->cnt; )
-                 if( !slotptr(parent->page, idx)->dead )
-                       break;
-
-               sibling->page_no = bt_getid (slotptr (parent->page, idx)->id);
-
-               bt_lockpage (BtLockDelete, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-
-               //      merge right if sibling shows up in
-               //  our parent and is not being killed
-
-               if( sibling->page_no == bt_getid (set->page->right) ) {
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-                 bt_lockpage (BtLockParent, sibling->latch);
-                 bt_lockpage (BtLockDelete, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
-
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_mergeright(bt, set, parent, sibling, slot, idx);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockParent, sibling->latch);
-                 bt_unlockpage (BtLockDelete, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
-
-               bt_unlockpage (BtLockDelete, set->latch);
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
-
-       //  find our left neighbor in our parent page
-
-       for( idx = slot; --idx; )
-         if( !slotptr(parent->page, idx)->dead )
-               break;
-
-       //      if no left neighbor, delete ourselves and our parent
-
-       if( !idx ) {
-               bt_lockpage (BtLockAccess, set->latch);
-               bt_lockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockAccess, set->latch);
-
-               rparent->page_no = bt_getid (parent->page->right);
-               rparent->latch = bt_pinlatch (bt, rparent->page_no);
-
-               bt_lockpage (BtLockAccess, rparent->latch);
-               bt_lockpage (BtLockWrite, rparent->latch);
-               bt_unlockpage (BtLockAccess, rparent->latch);
-
-               if( rparent->pool = bt_pinpool (bt, rparent->page_no) )
-                       rparent->page = bt_page (bt, rparent->pool, rparent->page_no);
-               else
-                       return bt->err;
-
-               if( !rparent->page->kill ) {
-                 sibling->page_no = bt_getid (set->page->right);
-                 sibling->latch = bt_pinlatch (bt, sibling->page_no);
-
-                 bt_lockpage (BtLockAccess, sibling->latch);
-                 bt_lockpage (BtLockWrite, sibling->latch);
-                 bt_unlockpage (BtLockAccess, sibling->latch);
-
-                 if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-                       sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-                 else
-                       return bt->err;
-
-                 if( !sibling->page->kill )
-                       return bt_removeparent (bt, set, parent, sibling, rparent, lvl+1);
-
-                 //  try again later
-
-                 bt_unlockpage (BtLockWrite, sibling->latch);
-                 bt_unpinlatch (sibling->latch);
-                 bt_unpinpool (sibling->pool);
-               }
+       // if key is found delete it, otherwise ignore request
 
-               bt_unlockpage (BtLockWrite, set->latch);
-               bt_unlockpage (BtLockWrite, rparent->latch);
-               bt_unpinlatch (rparent->latch);
-               bt_unpinpool (rparent->pool);
+       if( found = !keycmp (ptr, key, len) )
+         if( found = slotptr(set->page, slot)->dead == 0 ) {
+               dirty = slotptr(set->page, slot)->dead = 1;
+               set->page->dirty = 1;
+               set->page->act--;
 
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
-       }
+               // collapse empty slots
 
-       // redirect parent to our left sibling
-       // lock and map our left sibling's page
+               while( idx = set->page->cnt - 1 )
+                 if( slotptr(set->page, idx)->dead ) {
+                       *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
+                       memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
+                 } else
+                       break;
+         }
 
-       sibling->page_no = bt_getid (slotptr(parent->page, idx)->id);
-       sibling->latch = bt_pinlatch (bt, sibling->page_no);
+       //      did we delete a fence key in an upper level?
 
-       //      wait our turn on fence key maintenance
+       if( dirty && lvl && set->page->act && fence )
+         if( bt_fixfence (bt, set, lvl) )
+               return bt->err;
+         else
+               return bt->found = found, 0;
 
-       bt_lockpage(BtLockParent, sibling->latch);
-       bt_lockpage(BtLockAccess, sibling->latch);
-       bt_lockpage(BtLockWrite, sibling->latch);
-       bt_unlockpage(BtLockAccess, sibling->latch);
+       //      is this a collapsed root?
 
-       if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-       else
+       if( lvl > 1 && set->page_no == ROOT_page && set->page->act == 1 )
+         if( bt_collapseroot (bt, set) )
                return bt->err;
+         else
+               return bt->found = found, 0;
 
-       //  wait until left sibling is in our parent
+       //      return if page is not empty
 
-       if( bt_getid (sibling->page->right) != set->page_no ) {
-               bt_unlockpage (BtLockWrite, parent->latch);
-               bt_unlockpage (BtLockWrite, sibling->latch);
-               bt_unlockpage (BtLockParent, sibling->latch);
-               bt_unpinlatch (parent->latch);
-               bt_unpinpool (parent->pool);
-               bt_unpinlatch (sibling->latch);
-               bt_unpinpool (sibling->pool);
-#ifdef linux
-               sched_yield();
-#else
-               SwitchToThread();
-#endif
-               continue;
+       if( set->page->act ) {
+               bt_unlockpage(BtLockParentWrt, set->latch);
+               bt_unpinlatch (set->latch);
+               bt_unpinpool (set->pool);
+               return bt->found = found, 0;
        }
 
-       //      delete our left sibling from parent
-
-       slotptr(parent->page,idx)->dead = 1;
-       parent->page->dirty = 1;
-       parent->page->act--;
-
-       //      redirect our parent slot to our left sibling
-
-       bt_putid (slotptr(parent->page, slot)->id, sibling->page_no);
-       memcpy (sibling->page->right, set->page->right, BtId);
-
-       //      collapse dead slots from parent
-
-       while( idx = parent->page->cnt - 1 )
-         if( slotptr(parent->page, idx)->dead ) {
-               *slotptr(parent->page, idx) = *slotptr(parent->page, parent->page->cnt);
-               memset (slotptr(parent->page, parent->page->cnt--), 0, sizeof(BtSlot));
-         } else
-                 break;
-
-       //  free our original page
+       //      cache copy of fence key
+       //      to post in parent
 
-       bt_lockpage (BtLockDelete, set->latch);
-       bt_lockpage (BtLockWrite, set->latch);
-       bt_freepage (bt, set);
+       ptr = keyptr(set->page, set->page->cnt);
+       memcpy (lowerfence, ptr, ptr->len + 1);
 
-       //      go down the left node's fence keys to the leaf level
-       //      and update the fence keys in each page
+       //      obtain lock on right page
 
-       memcpy (newfence, parent->page->fence, 256);
+       right->page_no = bt_getid(set->page->right);
+       right->latch = bt_pinlatch (bt, right->page_no);
+       bt_lockpage (BtLockParentWrt, right->latch);
 
-       if( bt_fixfences (bt, sibling, newfence) )
-               return bt->err;
+       // pin page contents
 
-       //  promote sibling as new root?
+       if( right->pool = bt_pinpool (bt, right->page_no) )
+               right->page = bt_page (bt, right->pool, right->page_no);
+       else
+               return 0;
 
-       if( parent->page_no == ROOT_page && parent->page->cnt == 1 )
-        if( sibling->page->lvl ) {
-         sibling->latch = bt_pinlatch (bt, sibling->page_no);
-         bt_lockpage (BtLockDelete, sibling->latch);
-         bt_lockpage (BtLockWrite, sibling->latch);
+       if( right->page->kill )
+               return bt->err = BTERR_struct;
 
-         if( sibling->pool = bt_pinpool (bt, sibling->page_no) )
-               sibling->page = bt_page (bt, sibling->pool, sibling->page_no);
-         else
-               return bt->err;
+       // pull contents of right peer into our empty page
 
-         return bt_removeroot (bt, parent, sibling);
-        }
+       memcpy (set->page, right->page, bt->mgr->page_size);
 
-       bt_unlockpage (BtLockWrite, parent->latch);
-       bt_unpinlatch (parent->latch);
-       bt_unpinpool (parent->pool);
+       // cache copy of key to update
 
-       return 0;
-  }
-}
+       ptr = keyptr(right->page, right->page->cnt);
+       memcpy (higherfence, ptr, ptr->len + 1);
 
-//  find and delete key on page by marking delete flag bit
-//  if page becomes empty, delete it from the btree
+       // mark right page deleted and point it to left page
+       //      until we can post parent updates
 
-BTERR bt_deletekey (BtDb *bt, unsigned char *key, uint len)
-{
-unsigned char pagefence[256];
-uint slot, idx, found;
-BtPageSet set[1];
-BtKey ptr;
-
-       if( slot = bt_loadpage (bt, set, key, len, 0, BtLockWrite) )
-               ptr = keyptr(set->page, slot);
-       else
-               return bt->err;
+       bt_putid (right->page->right, set->page_no);
+       right->page->kill = 1;
 
-       // if key is found delete it, otherwise ignore request
+       bt_unlockpage (BtLockWrite, right->latch);
+       bt_unlockpage (BtLockWrite, set->latch);
 
-       if( found = slot <= set->page->cnt )
-         if( found = !keycmp (ptr, key, len) )
-               if( found = slotptr(set->page, slot)->dead == 0 ) {
-                 slotptr(set->page,slot)->dead = 1;
-                 set->page->dirty = 1;
-                 set->page->act--;
+       // redirect higher key directly to our new node contents
 
-                 // collapse empty slots
+       if( bt_insertkey (bt, higherfence+1, *higherfence, lvl+1, set->page_no, time(NULL)) )
+         return bt->err;
 
-                 while( idx = set->page->cnt - 1 )
-                       if( slotptr(set->page, idx)->dead ) {
-                         *slotptr(set->page, idx) = *slotptr(set->page, idx + 1);
-                         memset (slotptr(set->page, set->page->cnt--), 0, sizeof(BtSlot));
-                       } else
-                               break;
-               }
+       //      delete old lower key to our node
 
-       if( set->page->act ) {
-               bt_unlockpage(BtLockWrite, set->latch);
-               bt_unpinlatch (set->latch);
-               bt_unpinpool (set->pool);
-               return bt->found = found, 0;
-       }
+       if( bt_deletekey (bt, lowerfence+1, *lowerfence, lvl+1) )
+         return bt->err;
 
-       memcpy (pagefence, set->page->fence, 256);
-       set->page->kill = 1;
+       //      obtain delete and write locks to right node
 
-       bt_unlockpage (BtLockWrite, set->latch);
-
-       if( bt_removepage (bt, set, 0, pagefence) )
-               return bt->err;
+       bt_unlockpage (BtLockParent, right->latch);
+       bt_lockpage (BtLockDelete, right->latch);
+       bt_lockpage (BtLockWrite, right->latch);
+       bt_freepage (bt, right);
 
+       bt_unlockpage (BtLockParent, set->latch);
+       bt_unpinlatch (set->latch);
+       bt_unpinpool (set->pool);
        bt->found = found;
        return 0;
 }
@@ -2115,7 +1814,7 @@ BtKey ptr;
 
 uint bt_cleanpage(BtDb *bt, BtPage page, uint amt, uint slot)
 {
-uint nxt = bt->mgr->page_size, off;
+uint nxt = bt->mgr->page_size;
 uint cnt = 0, idx = 0;
 uint max = page->cnt;
 uint newslot = max;
@@ -2143,26 +1842,22 @@ BtKey key;
        while( cnt++ < max ) {
                if( cnt == slot )
                        newslot = idx + 1;
-               if( slotptr(bt->frame,cnt)->dead )
+               if( cnt < max && slotptr(bt->frame,cnt)->dead )
                        continue;
 
-               // if its not the fence key,
                // copy the key across
 
-               off = slotptr(bt->frame,cnt)->off;
-
-               if( off >= sizeof(*page) ) {
-                       key = keyptr(bt->frame, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)page + nxt, key, key->len + 1);
-               }
+               key = keyptr(bt->frame, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)page + nxt, key, key->len + 1);
 
                // copy slot
 
                memcpy(slotptr(page, ++idx)->id, slotptr(bt->frame, cnt)->id, BtId);
+               if( !(slotptr(page, idx)->dead = slotptr(bt->frame, cnt)->dead) )
+                       page->act++;
                slotptr(page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(page, idx)->off = off;
-               page->act++;
+               slotptr(page, idx)->off = nxt;
        }
 
        page->min = nxt;
@@ -2178,42 +1873,38 @@ BtKey key;
 
 // split the root and raise the height of the btree
 
-BTERR bt_splitroot(BtDb *bt, BtPageSet *root, uid page_no2)
+BTERR bt_splitroot(BtDb *bt, BtPageSet *root, unsigned char *leftkey, uid page_no2)
 {
 uint nxt = bt->mgr->page_size;
-unsigned char leftkey[256];
-uid new_page;
+uid left;
 
        //  Obtain an empty page to use, and copy the current
        //  root contents into it, e.g. lower keys
 
-       memcpy (leftkey, root->page->fence, 256);
-       root->page->posted = 1;
-
-       if( !(new_page = bt_newpage(bt, root->page)) )
+       if( !(left = bt_newpage(bt, root->page)) )
                return bt->err;
 
        // preserve the page info at the bottom
        // of higher keys and set rest to zero
 
        memset(root->page+1, 0, bt->mgr->page_size - sizeof(*root->page));
-       memset(root->page->fence, 0, 256);
-       root->page->fence[0] = 2;
-       root->page->fence[1] = 0xff;
-       root->page->fence[2] = 0xff;
 
-       // insert lower keys page fence key on newroot page
+       // insert lower keys page fence key on newroot page as first key
 
        nxt -= *leftkey + 1;
        memcpy ((unsigned char *)root->page + nxt, leftkey, *leftkey + 1);
-       bt_putid(slotptr(root->page, 1)->id, new_page);
+       bt_putid(slotptr(root->page, 1)->id, left);
        slotptr(root->page, 1)->off = nxt;
        
        // insert stopper key on newroot page
        // and increase the root height
 
+       nxt -= 3;
+       ((unsigned char *)root->page)[nxt] = 2;
+       ((unsigned char *)root->page)[nxt+1] = 0xff;
+       ((unsigned char *)root->page)[nxt+2] = 0xff;
        bt_putid(slotptr(root->page, 2)->id, page_no2);
-       slotptr(root->page, 2)->off = offsetof(struct BtPage_, fence);
+       slotptr(root->page, 2)->off = nxt;
 
        bt_putid(root->page->right, 0);
        root->page->min = nxt;          // reset lowest used offset and key count
@@ -2234,11 +1925,12 @@ uid new_page;
 
 BTERR bt_splitpage (BtDb *bt, BtPageSet *set)
 {
-uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size, off;
+uint cnt = 0, idx = 0, max, nxt = bt->mgr->page_size;
 unsigned char fencekey[256];
 uint lvl = set->page->lvl;
 uid right;
 BtKey key;
+uint prev;
 
        //  split higher half of keys to bt->frame
 
@@ -2248,23 +1940,17 @@ BtKey key;
        idx = 0;
 
        while( cnt++ < max ) {
-               if( !lvl || cnt < max ) {
-                       key = keyptr(set->page, cnt);
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
-               } else
-                       off = offsetof(struct BtPage_, fence);
+               key = keyptr(set->page, cnt);
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)bt->frame + nxt, key, key->len + 1);
 
                memcpy(slotptr(bt->frame,++idx)->id, slotptr(set->page,cnt)->id, BtId);
+               if( !(slotptr(bt->frame, idx)->dead = slotptr(set->page, cnt)->dead) )
+                       bt->frame->act++;
                slotptr(bt->frame, idx)->tod = slotptr(set->page, cnt)->tod;
-               slotptr(bt->frame, idx)->off = off;
-               bt->frame->act++;
+               slotptr(bt->frame, idx)->off = nxt;
        }
 
-       if( set->page_no == ROOT_page )
-               bt->frame->posted = 1;
-
-       memcpy (bt->frame->fence, set->page->fence, 256);
        bt->frame->bits = bt->mgr->page_bits;
        bt->frame->min = nxt;
        bt->frame->cnt = idx;
@@ -2295,24 +1981,17 @@ BtKey key;
 
        while( cnt++ < max / 2 ) {
                key = keyptr(bt->frame, cnt);
-
-               if( !lvl || cnt < max / 2 ) {
-                       off = nxt -= key->len + 1;
-                       memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
-               } else 
-                       off = offsetof(struct BtPage_, fence);
-
+               nxt -= key->len + 1;
+               memcpy ((unsigned char *)set->page + nxt, key, key->len + 1);
                memcpy(slotptr(set->page,++idx)->id, slotptr(bt->frame,cnt)->id, BtId);
                slotptr(set->page, idx)->tod = slotptr(bt->frame, cnt)->tod;
-               slotptr(set->page, idx)->off = off;
+               slotptr(set->page, idx)->off = nxt;
                set->page->act++;
        }
 
-       // install fence key for smaller key page
-
-       memset(set->page->fence, 0, 256);
-       memcpy(set->page->fence, key, key->len + 1);
+       // remember fence key for smaller page
 
+       memcpy(fencekey, key, key->len + 1);
        bt_putid(set->page->right, right);
        set->page->min = nxt;
        set->page->cnt = idx;
@@ -2320,9 +1999,10 @@ BtKey key;
        // if current page is the root page, split it
 
        if( set->page_no == ROOT_page )
-               return bt_splitroot (bt, set, right);
+               return bt_splitroot (bt, set, fencekey, right);
 
        bt_unlockpage (BtLockWrite, set->latch);
+       right = 0;
 
        // insert new fences in their parent pages
 
@@ -2330,10 +2010,11 @@ BtKey key;
                bt_lockpage (BtLockParent, set->latch);
                bt_lockpage (BtLockWrite, set->latch);
 
-               memcpy (fencekey, set->page->fence, 256);
-               right = bt_getid (set->page->right);
+               key = keyptr (set->page, set->page->cnt);
+               memcpy (fencekey, key, key->len + 1);
+               prev = set->page->posted;
 
-               if( set->page->posted ) {
+               if( right && prev ) {
                        bt_unlockpage (BtLockParent, set->latch);
                        bt_unlockpage (BtLockWrite, set->latch);
                        bt_unpinlatch (set->latch);
@@ -2341,10 +2022,15 @@ BtKey key;
                        return 0;
                }
 
+               right = bt_getid (set->page->right);
                set->page->posted = 1;
+
                bt_unlockpage (BtLockWrite, set->latch);
 
-               if( bt_insertkey (bt, fencekey+1, *fencekey, set->page_no, time(NULL), lvl+1) )
+               // insert new fence for reformulated left block of smaller keys
+
+               if( !prev )
+                 if( bt_insertkey (bt, fencekey+1, *fencekey, lvl+1, set->page_no, time(NULL)) )
                        return bt->err;
 
                bt_unlockpage (BtLockParent, set->latch);
@@ -2367,7 +2053,7 @@ BtKey key;
 
 //  Insert new key into the btree at given level.
 
-BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uid id, uint tod, uint lvl)
+BTERR bt_insertkey (BtDb *bt, unsigned char *key, uint len, uint lvl, uid id, uint tod)
 {
 BtPageSet set[1];
 uint slot, idx;
@@ -2385,8 +2071,7 @@ BtKey ptr;
 
                // if key already exists, update id and return
 
-               if( slot <= set->page->cnt )
-                 if( !keycmp (ptr, key, len) ) {
+               if( !keycmp (ptr, key, len) ) {
                        if( slotptr(set->page, slot)->dead )
                                set->page->act++;
                        slotptr(set->page, slot)->dead = 0;
@@ -2413,14 +2098,14 @@ BtKey ptr;
        ((unsigned char *)set->page)[set->page->min] = len;
        memcpy ((unsigned char *)set->page + set->page->min +1, key, len );
 
-       for( idx = slot; idx <= set->page->cnt; idx++ )
+       for( idx = slot; idx < set->page->cnt; idx++ )
          if( slotptr(set->page, idx)->dead )
                break;
 
        // now insert key into array before slot
 
-       if( idx > set->page->cnt )
-               set->page->cnt++;
+       if( idx == set->page->cnt )
+               idx++, set->page->cnt++;
 
        set->page->act++;
 
@@ -2470,6 +2155,7 @@ uid right;
 
   do {
        right = bt_getid(bt->cursor->right);
+
        while( slot++ < bt->cursor->cnt )
          if( slotptr(bt->cursor,slot)->dead )
                continue;
@@ -2497,6 +2183,7 @@ uid right;
        bt_unpinlatch (set->latch);
        bt_unpinpool (set->pool);
        slot = 0;
+
   } while( 1 );
 
   return bt->err = 0;
@@ -2523,10 +2210,11 @@ uint bt_tod(BtDb *bt, uint slot)
 void bt_latchaudit (BtDb *bt)
 {
 ushort idx, hashidx;
+uid next, page_no;
 BtLatchSet *latch;
 BtPool *pool;
 BtPage page;
-uid page_no;
+BtKey ptr;
 
 #ifdef unix
        for( idx = 1; idx < bt->mgr->latchmgr->latchdeployed; idx++ ) {
@@ -2563,18 +2251,21 @@ uid page_no;
          } while( idx = latch->next );
        }
 
-       page_no = bt_getid(bt->mgr->latchmgr->alloc[1].right);
-
-       while( page_no ) {
-               fprintf(stderr, "free: %.6x\n", (uint)page_no);
-
-               if( pool = bt_pinpool (bt, page_no) )
-                       page = bt_page (bt, pool, page_no);
-               else
-                       return;
-
-           page_no = bt_getid(page->right);
-               bt_unpinpool (pool);
+       next = bt->mgr->latchmgr->nlatchpage + LATCH_page;
+       page_no = LEAF_page;
+
+       while( page_no < bt_getid(bt->mgr->latchmgr->alloc->right) ) {
+               pread (bt->mgr->idx, bt->frame, bt->mgr->page_size, page_no << bt->mgr->page_bits);
+               if( !bt->frame->free )
+                for( idx = 0; idx++ < bt->frame->cnt - 1; ) {
+                 ptr = keyptr(bt->frame, idx+1);
+                 if( keycmp (keyptr(bt->frame, idx), ptr->key, ptr->len) >= 0 )
+                       fprintf(stderr, "page %.8x idx %.2x out of order\n", page_no, idx);
+                }
+
+               if( page_no > LEAF_page )
+                       next = page_no + 1;
+               page_no = next;
        }
 #endif
 }
@@ -2631,7 +2322,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_insertkey (bt, key, len, line, *tod, 0) )
+                         if( bt_insertkey (bt, key, len, 0, line, *tod) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2653,7 +2344,7 @@ FILE *in;
                          else if( args->num )
                                sprintf((char *)key+len, "%.9d", line + args->idx * args->num), len += 9;
 
-                         if( bt_deletekey (bt, key, len) )
+                         if( bt_deletekey (bt, key, len, 0) )
                                fprintf(stderr, "Error %d Line: %d\n", bt->err, line), exit(0);
                          len = 0;
                        }
@@ -2679,6 +2370,8 @@ FILE *in;
                                found++;
                          else if( bt->err )
                                fprintf(stderr, "Error %d Syserr %d Line: %d\n", bt->err, errno, line), exit(0);
+                         else
+                               fprintf(stderr, "Unable to find key %.*s line %d\n", len, key, line);
                          len = 0;
                        }
                        else if( len < 255 )