X-Git-Url: https://pd.if.org/git/?p=pdclib;a=blobdiff_plain;f=functions%2Fstdlib%2Fstrtoll.c;h=de7119429885cde06c589e24849e396f0915d36f;hp=b4476915b0a6b7c29fff1c17a8d8fa694746d01f;hb=da0f3f353d417fed71f358a48d5d5394145e460d;hpb=45f394553721285e7bc6187419613c33915cce21 diff --git a/functions/stdlib/strtoll.c b/functions/stdlib/strtoll.c index b447691..de71194 100644 --- a/functions/stdlib/strtoll.c +++ b/functions/stdlib/strtoll.c @@ -1,5 +1,3 @@ -/* $Id$ */ - /* strtoll( const char *, char * *, int ) This file is part of the Public Domain C Library (PDCLib). @@ -25,7 +23,6 @@ long long int strtoll( const char * s, char ** endptr, int base ) } else { - /* FIXME: This breaks on some machines that round negatives wrongly */ rc = (long long int)_PDCLIB_strtox_main( &p, (unsigned)base, (uintmax_t)LLONG_MIN, (uintmax_t)( LLONG_MIN / -base ), (int)( -( LLONG_MIN % base ) ), &sign ); } if ( endptr != NULL ) *endptr = ( p != NULL ) ? (char *) p : (char *) s; @@ -35,7 +32,7 @@ long long int strtoll( const char * s, char ** endptr, int base ) #endif #ifdef TEST -#include <_PDCLIB_test.h> +#include "_PDCLIB_test.h" #include @@ -88,7 +85,7 @@ int main( void ) /* for one-complement and signed magnitude just as well. Anyone having */ /* a platform to test this on? */ errno = 0; -#if LLONG_MAX == 0x7fffffffffffffffLL +#if LLONG_MAX >> 62 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtoll( "9223372036854775807", NULL, 0 ) == 0x7fffffffffffffff ); TESTCASE( errno == 0 ); @@ -102,7 +99,7 @@ int main( void ) TESTCASE( strtoll( "-9223372036854775809", NULL, 0 ) == LLONG_MIN ); TESTCASE( errno == ERANGE ); /* TODO: test "odd" overflow, i.e. base is not power of two */ -#elif LLONG_MAX == 0x7fffffffffffffffffffffffffffffffLL +#elif LLONG_MAX >> 126 == 1 /* testing "even" overflow, i.e. base is power of two */ TESTCASE( strtoll( "170141183460469231731687303715884105728", NULL, 0 ) == 0x7fffffffffffffffffffffffffffffff ); TESTCASE( errno == 0 );