From: solar <unknown>
Date: Thu, 2 Dec 2010 21:16:06 +0000 (+0000)
Subject: Testdriver for gets(). Turns out fseek() was not tested yet.
X-Git-Tag: v0.5~24
X-Git-Url: https://pd.if.org/git/?p=pdclib;a=commitdiff_plain;h=c0efd44abb3d05816f8e81006d225703e1d430d3

Testdriver for gets(). Turns out fseek() was not tested yet.
---

diff --git a/functions/stdio/fseek.c b/functions/stdio/fseek.c
index 9a94547..1c5332d 100644
--- a/functions/stdio/fseek.c
+++ b/functions/stdio/fseek.c
@@ -26,7 +26,7 @@ int fseek( struct _PDCLIB_file_t * stream, long offset, int whence )
     {
         stream->status &= ~ ( _PDCLIB_FREAD | _PDCLIB_FWRITE );
     }
-    return ( _PDCLIB_seek( stream, offset, whence ) == offset ) ? 0 : EOF;
+    return ( _PDCLIB_seek( stream, offset, whence ) != EOF ) ? 0 : EOF;
 }
 
 #endif
@@ -36,7 +36,7 @@ int fseek( struct _PDCLIB_file_t * stream, long offset, int whence )
 
 int main( void )
 {
-    /* Testing covered by ftell.c */
+    TESTCASE( NO_TESTDRIVER );
     return TEST_RESULTS;
 }
 
diff --git a/functions/stdio/gets.c b/functions/stdio/gets.c
index 9dbc515..6cefc48 100644
--- a/functions/stdio/gets.c
+++ b/functions/stdio/gets.c
@@ -22,27 +22,48 @@ char * gets( char * s )
     char * dest = s;
     while ( ( *dest = stdin->buffer[stdin->bufidx++] ) != '\n' )
     {
+        ++dest;
         if ( stdin->bufidx == stdin->bufend )
         {
             if ( _PDCLIB_fillbuffer( stdin ) == EOF )
             {
-                return NULL;
+                break;
             }
         }
-        ++dest;
     }
-    *dest = '\n';
-    return s;
+    *dest = '\0';
+    return ( dest == s ) ? NULL : s;
 }
 
 #endif
 
 #ifdef TEST
 #include <_PDCLIB_test.h>
+#include <string.h>
 
 int main( void )
 {
-    TESTCASE( NO_TESTDRIVER );
+    FILE * fh;
+    char buffer[10];
+    char const * gets_test = "foo\nbar\0baz\nweenie";
+    TESTCASE( ( fh = fopen( testfile, "wb" ) ) != NULL );
+    TESTCASE( fwrite( gets_test, 1, 18, fh ) == 18 );
+    TESTCASE( fclose( fh ) == 0 );
+    TESTCASE( ( fh = freopen( testfile, "rb", stdin ) ) != NULL );
+    TESTCASE( gets( buffer ) == buffer );
+    TESTCASE( strcmp( buffer, "foo" ) == 0 );
+    TESTCASE( gets( buffer ) == buffer );
+    TESTCASE( memcmp( buffer, "bar\0baz\0", 8 ) == 0 );
+    TESTCASE( gets( buffer ) == buffer );
+    TESTCASE( strcmp( buffer, "weenie" ) == 0 );
+    TESTCASE( feof( fh ) );
+    TESTCASE( fseek( fh, -1, SEEK_END ) == 0 );
+    TESTCASE( gets( buffer ) == buffer );
+    TESTCASE( strcmp( buffer, "e" ) == 0 );
+    TESTCASE( feof( fh ) );
+    TESTCASE( fseek( fh, 0, SEEK_END ) == 0 );
+    TESTCASE( gets( buffer ) == NULL );
+    // remove( testfile );
     return TEST_RESULTS;
 }