From 50c9c6af3784c1fce7a82c50df1e7ef8f9b57bd4 Mon Sep 17 00:00:00 2001
From: solar <unknown>
Date: Sun, 12 Dec 2010 21:32:44 +0000
Subject: [PATCH] Whoops. That wouldn't have worked...

---
 functions/stdio/ftell.c                       | 25 ++++++++++++++-----
 .../example/functions/_PDCLIB/fillbuffer.c    |  1 +
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/functions/stdio/ftell.c b/functions/stdio/ftell.c
index 892c7b2..63c7f75 100644
--- a/functions/stdio/ftell.c
+++ b/functions/stdio/ftell.c
@@ -13,8 +13,10 @@
 
 long int ftell( struct _PDCLIB_file_t * stream )
 {
-    /* FIXME: A bit too fuzzy in the head now. stream->ungetidx should be in here
-             somewhere.
+    /* If offset is too large for return type, report error instead of wrong
+       offset value.
+       FIXME: A bit too fuzzy in the head right now; stream->ungetidx should be
+       in here somewhere.
     */
     if ( stream->pos.offset > ( LONG_MAX - stream->bufidx ) )
     {
@@ -22,11 +24,22 @@ long int ftell( struct _PDCLIB_file_t * stream )
         _PDCLIB_errno = _PDCLIB_EINVAL;
         return -1;
     }
-    /* Position of start-of-buffer, plus:
-       - buffered, unwritten content (for output streams), or
-       - already-parsed content from buffer (for input streams)
+    /* ftell() must take into account:
+       - the actual *physical* offset of the file, i.e. the offset as recognized
+         by the operating system (and stored in stream->pos.offset); and
+       - any buffers held by PDCLib, which
+         - in case of unwritten buffers, count in *addition* to the offset; or
+         - in case of unprocessed pre-read buffers, count in *substraction* to
+           the offset. (Remember to count ungetidx into this number.)
+       Conveniently, the calculation ( ( bufend - bufidx ) + ungetidx ) results
+       in just the right number in both cases:
+         - in case of unwritten buffers, ( ( 0 - unwritten ) + 0 )
+           i.e. unwritten bytes as negative number
+         - in case of unprocessed pre-read, ( ( preread - processed ) + unget )
+           i.e. unprocessed bytes as positive number.
+       That is how the somewhat obscure return-value calculation works.
     */
-    return (long int)( stream->pos.offset + stream->bufidx - stream->ungetidx );
+    return (long int)( stream->pos.offset - ( ( stream->bufend - stream->bufidx ) + stream->ungetidx ) );
 }
 
 #endif
diff --git a/platform/example/functions/_PDCLIB/fillbuffer.c b/platform/example/functions/_PDCLIB/fillbuffer.c
index ecfb968..8da93ad 100644
--- a/platform/example/functions/_PDCLIB/fillbuffer.c
+++ b/platform/example/functions/_PDCLIB/fillbuffer.c
@@ -31,6 +31,7 @@ int _PDCLIB_fillbuffer( struct _PDCLIB_file_t * stream )
         {
             /* TODO: Text stream conversion here */
         }
+        stream->pos.offset += rc;
         stream->bufend = rc;
         stream->bufidx = 0;
         return 0;
-- 
2.40.0