#include <stdlib.h>
#ifndef REGTEST
+#include <_PDCLIB_io.h>
#include <_PDCLIB_glue.h>
+#include <string.h>
+#include <errno.h>
-/* FIXME: This approach is a possible attack vector. */
-struct _PDCLIB_file_t * _PDCLIB_filelist = NULL;
+extern FILE * _PDCLIB_filelist;
-/* Helper function that parses the C-style mode string passed to fopen() into
- the PDCLib flags FREAD, FWRITE, FAPPEND, FRW (read-write) and FBIN (binary
- mode).
-*/
-static unsigned int filemode( char const * const mode )
+FILE * fopen( const char * _PDCLIB_restrict filename,
+ const char * _PDCLIB_restrict mode )
{
- int rc = 0;
- switch ( mode[0] )
- {
- case 'r':
- rc |= _PDCLIB_FREAD;
- break;
- case 'w':
- rc |= _PDCLIB_FWRITE;
- break;
- case 'a':
- rc |= _PDCLIB_FAPPEND;
- break;
- default:
- /* Other than read, write, or append - invalid */
- return 0;
- }
- for ( size_t i = 1; i < 4; ++i )
- {
- switch ( mode[i] )
- {
- case '+':
- if ( rc & _PDCLIB_FRW ) return 0; /* Duplicates are invalid */
- rc |= _PDCLIB_FRW;
- break;
- case 'b':
- if ( rc & _PDCLIB_FBIN ) return 0; /* Duplicates are invalid */
- rc |= _PDCLIB_FBIN;
- break;
- case '\0':
- /* End of mode */
- return rc;
- default:
- /* Other than read/write or binary - invalid. */
- return 0;
- }
- }
- /* Longer than three chars - invalid. */
- return 0;
-}
+ int imode = _PDCLIB_filemode( mode );
+
+ if( imode == 0 || filename == NULL )
+ return NULL;
-struct _PDCLIB_file_t * fopen( const char * _PDCLIB_restrict filename, const char * _PDCLIB_restrict mode )
-{
- struct _PDCLIB_file_t * rc;
- if ( mode == NULL || filename == NULL || filename[0] == '\0' )
- {
- /* Mode or filename invalid */
+ _PDCLIB_fd_t fd;
+ const _PDCLIB_fileops_t * ops;
+ if(!_PDCLIB_open( &fd, &ops, filename, imode )) {
return NULL;
}
- if ( ( rc = calloc( 1, sizeof( struct _PDCLIB_file_t ) ) ) == NULL )
- {
- /* no memory for another FILE */
- return NULL;
+
+ FILE * f = _PDCLIB_fvopen( fd, ops, imode, filename );
+ if(!f) {
+ int saveErrno = errno;
+ ops->close(fd);
+ errno = saveErrno;
}
- if ( ( rc->status = filemode( mode ) ) == 0 ) goto fail; /* invalid mode */
- rc->handle = _PDCLIB_open( filename, rc->status );
- if ( rc->handle == _PDCLIB_NOHANDLE ) goto fail; /* OS open() failed */
- /* Adding to list of open files */
- rc->next = _PDCLIB_filelist;
- _PDCLIB_filelist = rc;
- /* Setting buffer, and mark as internal. TODO: Check for unbuffered? */
- if ( ( rc->buffer = malloc( BUFSIZ ) ) == NULL ) goto fail;
- rc->bufsize = BUFSIZ;
- rc->status |= ( _PDCLIB_LIBBUFFER | _PDCLIB_VIRGINSTR );
- /* TODO: Setting mbstate */
- return rc;
-fail:
- free( rc );
- return NULL;
+ return f;
}
#endif
int main( void )
{
-#ifndef REGTEST
- TESTCASE( filemode( "r" ) == _PDCLIB_FREAD );
- TESTCASE( filemode( "w" ) == _PDCLIB_FWRITE );
- TESTCASE( filemode( "a" ) == _PDCLIB_FAPPEND );
- TESTCASE( filemode( "r+" ) == ( _PDCLIB_FREAD | _PDCLIB_FRW ) );
- TESTCASE( filemode( "w+" ) == ( _PDCLIB_FWRITE | _PDCLIB_FRW ) );
- TESTCASE( filemode( "a+" ) == ( _PDCLIB_FAPPEND | _PDCLIB_FRW ) );
- TESTCASE( filemode( "rb" ) == ( _PDCLIB_FREAD | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "wb" ) == ( _PDCLIB_FWRITE | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "ab" ) == ( _PDCLIB_FAPPEND | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "r+b" ) == ( _PDCLIB_FREAD | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "w+b" ) == ( _PDCLIB_FWRITE | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "a+b" ) == ( _PDCLIB_FAPPEND | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "rb+" ) == ( _PDCLIB_FREAD | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "wb+" ) == ( _PDCLIB_FWRITE | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( filemode( "ab+" ) == ( _PDCLIB_FAPPEND | _PDCLIB_FRW | _PDCLIB_FBIN ) );
- TESTCASE( fopen( NULL, NULL ) == NULL );
+ /* Some of the tests are not executed for regression tests, as the libc on
+ my system is at once less forgiving (segfaults on mode NULL) and more
+ forgiving (accepts undefined modes).
+ */
+ FILE * fh;
+ remove( testfile );
+ TESTCASE_NOREG( fopen( NULL, NULL ) == NULL );
TESTCASE( fopen( NULL, "w" ) == NULL );
- TESTCASE( fopen( "", NULL ) == NULL );
+ TESTCASE_NOREG( fopen( "", NULL ) == NULL );
TESTCASE( fopen( "", "w" ) == NULL );
TESTCASE( fopen( "foo", "" ) == NULL );
- TESTCASE( fopen( "testfile", "wq" ) == NULL ); /* Illegal mode */
- TESTCASE( fopen( "testfile", "wr" ) == NULL ); /* Illegal mode */
- TESTCASE( fopen( "testfile", "w" ) != NULL );
- system( "rm testfile" );
-#else
- puts( " NOTEST fopen() test driver is PDCLib-specific." );
-#endif
+ TESTCASE_NOREG( fopen( testfile, "wq" ) == NULL ); /* Undefined mode */
+ TESTCASE_NOREG( fopen( testfile, "wr" ) == NULL ); /* Undefined mode */
+ TESTCASE( ( fh = fopen( testfile, "w" ) ) != NULL );
+ TESTCASE( fclose( fh ) == 0 );
+ TESTCASE( remove( testfile ) == 0 );
return TEST_RESULTS;
}