Added test driver, fixed off-by-one bug.

[pdclib] / functions / string / memmove.c

diff --git a/functions/string/memmove.c b/functions/string/memmove.c
index 4ba2ba4cf2feafbc30fd0e9c5eb060f85653c02b..e9a52b20ed8864a6078121eabb75b3c3a4fd9e9c 100644 (file)
--- a/functions/string/memmove.c
+++ b/functions/string/memmove.c
@@ -14,7 +14,7 @@ void * memmove( void * s1, const void * s2, size_t n )
 {
     char * dest = (char *) s1;
     const char * src = (const char *) s2;
-    if ( dest < src )
+    if ( dest <= src )
     {
         while ( n-- )
         {
@@ -27,10 +27,25 @@ void * memmove( void * s1, const void * s2, size_t n )
         dest += n;
         while ( n-- )
         {
-            *dest-- = *src--;
+            *--dest = *--src;
         }
     }
     return s1;
 }
 
-#warning Test driver missing.
+#ifdef TEST
+#include <_PDCLIB_test.h>
+
+int main()
+{
+    char s[10] = "xxxxabcde";
+    BEGIN_TESTS;
+    TESTCASE( memmove( s, s + 4, 5 ) == s );
+    TESTCASE( s[0] == 'a' );
+    TESTCASE( s[4] == 'e' );
+    TESTCASE( s[5] == 'b' );
+    TESTCASE( memmove( s + 4, s, 5 ) == s + 4 );
+    TESTCASE( s[4] == 'a' );
+    return TEST_RESULTS;
+}
+#endif