Cleaning up TODOs.

[pdclib] / platform / example_cygwin / functions / signal / raise.c

diff --git a/platform/example_cygwin/functions/signal/raise.c b/platform/example_cygwin/functions/signal/raise.c
index b16249c2ee75c0dc1941b9944a8ef7bbe0f17f38..8d7080b143e5b2e476e53c0cb0cf2605df49fd76 100644 (file)
--- a/platform/example_cygwin/functions/signal/raise.c
+++ b/platform/example_cygwin/functions/signal/raise.c
@@ -10,6 +10,7 @@
 
 #ifndef REGTEST
 
+#include <stdio.h>
 #include <stdlib.h>
 
 extern void (*_PDCLIB_sigabrt)( int );
@@ -22,32 +23,40 @@ extern void (*_PDCLIB_sigterm)( int );
 int raise( int sig )
 {
     void (*sighandler)( int );
+    char const * message;
     switch ( sig )
     {
         case SIGABRT:
             sighandler = _PDCLIB_sigabrt;
+            message = "Abnormal termination (SIGABRT)";
             break;
         case SIGFPE:
             sighandler = _PDCLIB_sigfpe;
+            message = "Arithmetic exception (SIGFPE)";
             break;
         case SIGILL:
             sighandler = _PDCLIB_sigill;
+            message = "Illegal instruction (SIGILL)";
             break;
         case SIGINT:
             sighandler = _PDCLIB_sigint;
+            message = "Interactive attention signal (SIGINT)";
             break;
         case SIGSEGV:
             sighandler = _PDCLIB_sigsegv;
+            message = "Invalid memory access (SIGSEGV)";
             break;
         case SIGTERM:
             sighandler = _PDCLIB_sigterm;
+            message = "Termination request (SIGTERM)";
             break;
         default:
-            /* TODO: Implement. */
-            break;
+            fprintf( stderr, "Unknown signal #%d\n", sig );
+            _Exit( EXIT_FAILURE );
     }
     if ( sighandler == SIG_DFL )
     {
+        fputs( message, stderr );
         _Exit( EXIT_FAILURE );
     }
     else if ( sighandler != SIG_IGN )
@@ -63,9 +72,43 @@ int raise( int sig )
 #ifdef TEST
 #include <_PDCLIB_test.h>
 
+#include <stdlib.h>
+
+static volatile sig_atomic_t flag = 0;
+
+static int expected_signal = 0;
+
+static void test_handler( int sig )
+{
+    TESTCASE( sig == expected_signal );
+    flag = 1;
+}
+
 int main( void )
 {
-    TESTCASE( NO_TESTDRIVER );
+    /* Could be other than SIG_DFL if you changed the implementation. */
+    TESTCASE( signal( SIGABRT, SIG_IGN ) == SIG_DFL );
+    /* Should be ignored. */
+    TESTCASE( raise( SIGABRT ) == 0 );
+    /* Installing test handler, old handler should be returned */
+    TESTCASE( signal( SIGABRT, test_handler ) == SIG_IGN );
+    /* Raising and checking SIGABRT */
+    expected_signal = SIGABRT;
+    TESTCASE( raise( SIGABRT ) == 0 );
+    TESTCASE( flag == 1 );
+    /* Re-installing test handler, should have been reset to default */
+    /* Could be other than SIG_DFL if you changed the implementation. */
+    TESTCASE( signal( SIGABRT, test_handler ) == SIG_DFL );
+    /* Raising and checking SIGABRT */
+    flag = 0;
+    TESTCASE( raise( SIGABRT ) == 0 );
+    TESTCASE( flag == 1 );
+    /* Installing test handler for different signal... */
+    TESTCASE( signal( SIGTERM, test_handler ) == SIG_DFL );
+    /* Raising and checking SIGTERM */
+    expected_signal = SIGTERM;
+    TESTCASE( raise( SIGTERM ) == 0 );
+    TESTCASE( flag == 1 );
     return TEST_RESULTS;
 }
 #endif